Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1205048

RE: [v2 8/9] dpaa_eth: add debugfs entries

From Madalin-Cristian Bucur <madalin.bucur@freescale.com>
Newsgroups linux.kernel
Subject RE: [v2 8/9] dpaa_eth: add debugfs entries
Date 2015-08-11 13:10 +0200
Message-ID <pWfBo-3hD-5@gated-at.bofh.it> (permalink)
References <pU974-5Ga-19@gated-at.bofh.it> <pUYsV-4St-9@gated-at.bofh.it> <pUYsV-4St-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> 
> From: Madalin Bucur <madalin.bucur@freescale.com>
> Date: Wed, 5 Aug 2015 18:41:28 +0300
> 
> > Export per CPU counters through debugfs.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> 
> This is absolutely inappropriate.
> 
> You can export these just fine via ethtool statistics.  There is zero reason
> to add ugly debugfs crap for something like this.

If you have such a strong adversity about the debugfs, then I'll export these
debug counters through ethtool statistics in the next version.

Madalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[v2 0/9] dpaa_eth: Add the Freescale DPAA Ethernet driver Madalin Bucur <madalin.bucur@freescale.com> - 2015-08-05 17:50 +0200
  Re: [v2 8/9] dpaa_eth: add debugfs entries David Miller <davem@davemloft.net> - 2015-08-08 00:40 +0200
    RE: [v2 8/9] dpaa_eth: add debugfs entries Madalin-Cristian Bucur <madalin.bucur@freescale.com> - 2015-08-11 13:10 +0200
  Re: [v2 2/9] dpaa_eth: add support for DPAA Ethernet Florian Fainelli <f.fainelli@gmail.com> - 2015-08-08 19:40 +0200

csiph-web