Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1204994
| Path | csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!bofh.it!news.nic.it!robomod |
|---|---|
| From | Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue |
| Date | Tue, 11 Aug 2015 12:10:01 +0200 |
| Message-ID | <pWeFj-1Wr-9@gated-at.bofh.it> (permalink) |
| References | <pWeci-17Z-9@gated-at.bofh.it> <pWelZ-1jK-29@gated-at.bofh.it> |
| X-Original-To | Jacek Anaszewski <j.anaszewski@samsung.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=kCJVacxfHndb4K1P8jT5A0RhCHv6o778vbzNRLtBmuo=; b=blc52fhH6F0xRWSO23gTPAShYv1OCytkHSREFalBFe19Fw0eW/QSRzAuEEz83Zdz0r hExtKvHlyqOcw+aeldPgMqzMttdzu/H9wRHt/ud95NrwfcO3DJuQo9VJWqi6O8YB3Jai v2FXO5cKy8S9SMghZmnkIDeOxM0Bt/+LEMrEcw5+8j225z5dNXJs486hZJIBOLO/3/tc fPlpwOe889IBGqXrXRFE6pGfylY84sNjpiW9rlvMQnBsYSqCHWxGvaXy9466CY3wyBRX k+rJ6G5NxZ4Xetys8aQEF6QTllb9E0gYn67seVg6CeTj4lxXy21r/gDF1kbJdWo9GJwj fz6A== |
| X-Received | by 10.152.23.234 with SMTP id p10mr25264154laf.52.1439287252244; Tue, 11 Aug 2015 03:00:52 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 45 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Linux LED Subsystem <linux-leds@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>, stsp@users.sourceforge.net, Andrew Lunn <andrew@lunn.ch>, Peter Meerwald <p.meerwald@bct-electronic.com> |
| X-Original-Date | Tue, 11 Aug 2015 12:00:32 +0200 |
| X-Original-Message-ID | <CAPybu_3Wt8QCk1oZeNx_0jSLgapLOyyeOfxW3zVkc08mXsgP9A@mail.gmail.com> |
| X-Original-References | <1439285890-27329-1-git-send-email-j.anaszewski@samsung.com> <1439285890-27329-26-git-send-email-j.anaszewski@samsung.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1204994 |
Show key headers only | View raw
Hello Jacek
Sorry for the late reply.
On Tue, Aug 11, 2015 at 11:37 AM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> struct pca963x_led {
> struct pca963x *chip;
> - struct work_struct work;
> enum led_brightness brightness;
> struct led_classdev led_cdev;
> int led_num; /* 0 .. 15 potentially */
> - enum pca963x_cmd cmd;
> char name[32];
> u8 gdc;
> u8 gfrq;
> };
Maybe you want to remove also brightness, gdc and gfrq and pass them
as arguments to the functions.
> -static void pca963x_blink_work(struct pca963x_led *pca963x)
> +static void pca963x_blink(struct pca963x_led *pca963x)
something like: blink(pca963x, gdc, gfrq)
Big disclaimer: i havent tested it on real hardware. Maybe next week I
can get hold of a board with a pca chip.
BTW: great thing that the work queue is implemented in the core :)
Cheers!
--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH/RFC v5 25/57] leds: pca963x: Remove work queue Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-08-11 11:50 +0200
Re: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue Peter Meerwald <p.meerwald@bct-electronic.com> - 2015-08-11 11:50 +0200
Re: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2015-08-11 12:10 +0200
Re: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-08-11 12:40 +0200
csiph-web