Groups > linux.kernel > #1204880

Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2()

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2()
Date	2015-08-11 10:40 +0200
Message-ID	<pWdge-8dF-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <pW5C3-5yL-11@gated-at.bofh.it> <pW5LI-5JT-1@gated-at.bofh.it> <pW7u9-8lO-3@gated-at.bofh.it> <pWaV3-4VF-5@gated-at.bofh.it> <pWbHr-5QC-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11-08-15, 12:27, Viresh Kumar wrote:
> diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
> index 1daaa1a418a2..be3356a3a452 100644
> --- a/drivers/base/power/opp.c
> +++ b/drivers/base/power/opp.c
> @@ -1292,14 +1292,18 @@ static int _of_init_opp_table_v2(struct device *dev,
>  	}
>  
>  	/* There should be one of more OPP defined */
> -	if (WARN_ON(!count))
> +	if (WARN_ON(!count)) {
> +		ret = -ENOENT;
>  		goto out;
> +	}
>  
>  	if (!ret) {
>  		if (!dev_opp) {
>  			dev_opp = _find_device_opp(dev);
> -			if (WARN_ON(!dev_opp))
> +			if (WARN_ON(!dev_opp)) {

Dan also reported that !dev_opp isn't enough as we need to use IS_ERR
here.

We have got enough updates here, let me resend the series again to get
more reviews on proper patches.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-10 08:40 +0200
  Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Stephen Boyd <sboyd@codeaurora.org> - 2015-08-10 21:30 +0200
    Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-11 02:30 +0200
      Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Stephen Boyd <sboyd@codeaurora.org> - 2015-08-11 02:40 +0200
        Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-11 04:30 +0200
          Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Stephen Boyd <sboyd@codeaurora.org> - 2015-08-11 08:10 +0200
            Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-11 09:00 +0200
              Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-11 10:40 +0200
        Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-11 04:40 +0200
          Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2() Stephen Boyd <sboyd@codeaurora.org> - 2015-08-11 08:10 +0200

csiph-web