Groups > linux.kernel > #1204859

Re: [patch] quota: remove an unneeded condition

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [patch] quota: remove an unneeded condition
Date	Tue, 11 Aug 2015 10:10:01 +0200
Message-ID	<pWcNb-7FX-5@gated-at.bofh.it> (permalink)
References	<pW2Xv-1EC-13@gated-at.bofh.it>
X-Original-To	Dan Carpenter <dan.carpenter@oracle.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Jan Kara <jack@suse.com>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
X-Original-Date	Tue, 11 Aug 2015 10:03:11 +0200
X-Original-Message-ID	<20150811080311.GC2650@quack.suse.cz>
X-Original-References	<20150810212955.GA31724@mwanda>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1204859

Show key headers only | View raw

On Tue 11-08-15 00:29:55, Dan Carpenter wrote:
> We know "ret" is zero here so we can remove this condition.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks. I've added the patch to my tree.

								Honza

> diff --git a/fs/quota/quota.c b/fs/quota/quota.c
> index 86ded73..3746367 100644
> --- a/fs/quota/quota.c
> +++ b/fs/quota/quota.c
> @@ -141,9 +141,9 @@ static int quota_getinfo(struct super_block *sb, int type, void __user *addr)
>  	if (tstate->flags & QCI_ROOT_SQUASH)
>  		uinfo.dqi_flags |= DQF_ROOT_SQUASH;
>  	uinfo.dqi_valid = IIF_ALL;
> -	if (!ret && copy_to_user(addr, &uinfo, sizeof(uinfo)))
> +	if (copy_to_user(addr, &uinfo, sizeof(uinfo)))
>  		return -EFAULT;
> -	return ret;
> +	return 0;
>  }
>  
>  static int quota_setinfo(struct super_block *sb, int type, void __user *addr)
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] quota: remove an unneeded condition Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-10 23:40 +0200
  Re: [patch] quota: remove an unneeded condition Jan Kara <jack@suse.cz> - 2015-08-11 10:10 +0200

csiph-web