Groups > linux.kernel > #1204832

Re: [PATCH RFC] serial: mxs-auart: fix baud rate range

From	Stefan Wahren <stefan.wahren@i2se.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC] serial: mxs-auart: fix baud rate range
Date	2015-08-11 09:20 +0200
Message-ID	<pWc0O-6sl-5@gated-at.bofh.it> (permalink)
References	<pVUdA-62u-27@gated-at.bofh.it> <pVUng-6dN-9@gated-at.bofh.it> <pVYKe-4b1-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Janusz,

> Janusz Użycki <j.uzycki@elpromaelectronics.com> hat am 10. August 2015 um
> 19:01 geschrieben:
>
>
>
>
> W dniu 2015-08-10 o 14:22, Fabio Estevam pisze:
> > On Mon, Aug 10, 2015 at 9:12 AM, Stefan Wahren <stefan.wahren@i2se.com>
> > wrote:
> >
> >> /* set baud rate */
> >> - baud = uart_get_baud_rate(u, termios, old, 0, u->uartclk);
> >> + baud_min = u->uartclk * 32 / 0x3fffc0;
> >> + baud_max = u->uartclk * 32 / 0xec;
> >> + baud = uart_get_baud_rate(u, termios, old, baud_min, baud_max);
> > Looks good. It would be nice to replace 0x3fffc0 and 0xec with defines
> > though.
>
> I agree with Fabio.

i will name them AUART_LINECTRL_BAUD_DIV_MIN and AUART_LINECTRL_BAUD_DIV_MAX.

>
> In addition let's look at the example for uartclk = 24MHz:
> baud_max = 3,254,237.29 => will be rounded down to 3,254,237bauds and it
> is OK
> baud_min = 183.1 => will be rounded to 183 bauds. To avoid div=0x400971
> it should be 184
> so DIV_ROUND_UP() macro could be used.

Thanks for pointing out. I will fix that.

Best regards
Stefan

>
> best regards
> Janusz
>
> >
> > Regards,
> >
> > Fabio Estevam
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC] serial: mxs-auart: fix baud rate range Stefan Wahren <stefan.wahren@i2se.com> - 2015-08-10 14:20 +0200
  Re: [PATCH RFC] serial: mxs-auart: fix baud rate range Fabio Estevam <festevam@gmail.com> - 2015-08-10 14:30 +0200
    Re: [PATCH RFC] serial: mxs-auart: fix baud rate range Janusz Użycki <j.uzycki@elpromaelectronics.com> - 2015-08-10 19:10 +0200
      Re: [PATCH RFC] serial: mxs-auart: fix baud rate range Stefan Wahren <stefan.wahren@i2se.com> - 2015-08-11 09:20 +0200

csiph-web