Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1206460
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [f2fs-dev] [PATCH 2/2 v3] f2fs: skip checkpoint if there is no dirty segments |
| Date | 2015-08-13 03:30 +0200 |
| Message-ID | <pWPvc-57e-7@gated-at.bofh.it> (permalink) |
| References | <pW6y5-6TZ-5@gated-at.bofh.it> <pW6y5-6TZ-3@gated-at.bofh.it> <pWwsx-2Cs-3@gated-at.bofh.it> <pWAPy-Bo-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Change log from v2:
- consider omitting current dirty segments
From 181cb245f6a406e89c00976f65a5727956a72942 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim <jaegeuk@kernel.org>
Date: Tue, 11 Aug 2015 21:59:49 -0700
Subject: [PATCH] f2fs: skip checkpoint if there is no dirty and prefree
segments
We should avoid needless checkpoints when there is no dirty and prefree segment.
eviewed-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/gc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index fcb263a..81de28d8 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -792,7 +792,8 @@ static void do_garbage_collect(struct f2fs_sb_info *sbi, unsigned int segno,
int f2fs_gc(struct f2fs_sb_info *sbi)
{
- unsigned int segno, i;
+ unsigned int segno = NULL_SEGNO;
+ unsigned int i;
int gc_type = BG_GC;
int nfree = 0;
int ret = -1;
@@ -811,10 +812,11 @@ gc_more:
if (gc_type == BG_GC && has_not_enough_free_secs(sbi, nfree)) {
gc_type = FG_GC;
- write_checkpoint(sbi, &cpc);
+ if (__get_victim(sbi, &segno, gc_type) || prefree_segments(sbi))
+ write_checkpoint(sbi, &cpc);
}
- if (!__get_victim(sbi, &segno, gc_type))
+ if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type))
goto stop;
ret = 0;
--
2.1.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 2/2] f2fs: skip checkpoint if there is no dirty segments Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-11 03:30 +0200
Re: [PATCH 2/2 v2] f2fs: skip checkpoint if there is no dirty segments Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-12 07:10 +0200
RE: [f2fs-dev] [PATCH 2/2 v2] f2fs: skip checkpoint if there is no dirty segments Chao Yu <chao2.yu@samsung.com> - 2015-08-12 11:50 +0200
Re: [f2fs-dev] [PATCH 2/2 v3] f2fs: skip checkpoint if there is no dirty segments Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-13 03:30 +0200
csiph-web