Groups > linux.kernel > #1206298

Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem

From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem
Date	2015-08-12 19:50 +0200
Message-ID	<pWIk1-2ZP-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <pW8zT-1qd-5@gated-at.bofh.it> <pW8JB-1BB-33@gated-at.bofh.it> <pWwiS-24c-13@gated-at.bofh.it> <pWFcu-70d-15@gated-at.bofh.it> <pWHHl-2fW-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-08-12 at 20:00 +0300, Sorin Dumitru wrote:

> Would clamping the values to a min value, like setsockopt(SO_SNDBUF)
> does, be an option?
> I still find it odd that SO_SNDBUF limits you, while the /proc
> interface doesn't. If you think it's
> too much, I'm ok with reverting it since it affects scripts.
> 
> On those arches where PAGE_SIZE == 64K(or > 16K) it looks like we have
> tcp_wmem[1]
> smaller than tcp_wmem[0]. Shouldn't we do something about this?

As long as we do not crash if/when root user changes /proc/sys/net
settings, we are good.

I would not care if performance is bad if root does something really
stupid. root user is supposed to not mess things just for fun.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min Calvin Owens <calvinowens@fb.com> - 2015-08-05 22:30 +0200
  Re: [PATCH] net: Unbreak resetting default values for  tcp_wmem/udp_wmem_min David Miller <davem@davemloft.net> - 2015-08-10 07:50 +0200
    Re: [PATCH] net: Unbreak resetting default values for  tcp_wmem/udp_wmem_min Calvin Owens <calvinowens@fb.com> - 2015-08-11 05:40 +0200
      Re: [PATCH] net: Unbreak resetting default values for  tcp_wmem/udp_wmem_min David Miller <davem@davemloft.net> - 2015-08-11 05:50 +0200
        [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem Calvin Owens <calvinowens@fb.com> - 2015-08-12 07:00 +0200
          Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem Eric Dumazet <eric.dumazet@gmail.com> - 2015-08-12 16:30 +0200
            Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem Sorin Dumitru <sorin@returnze.ro> - 2015-08-12 19:10 +0200
              Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem Eric Dumazet <eric.dumazet@gmail.com> - 2015-08-12 19:50 +0200
                Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem Calvin Owens <calvinowens@fb.com> - 2015-08-13 23:10 +0200
          [PATCH] Revert "net: limit tcp/udp rmem/wmem to  SOCK_{RCV,SND}BUF_MIN" Calvin Owens <calvinowens@fb.com> - 2015-08-13 23:30 +0200
            Re: [PATCH] Revert "net: limit tcp/udp rmem/wmem to  SOCK_{RCV,SND}BUF_MIN" Eric Dumazet <eric.dumazet@gmail.com> - 2015-08-14 01:00 +0200
            Re: [PATCH] Revert "net: limit tcp/udp rmem/wmem to  SOCK_{RCV,SND}BUF_MIN" David Miller <davem@davemloft.net> - 2015-08-17 21:20 +0200

csiph-web