Groups > linux.kernel > #1206158

Re: [PATCH] Bluetooth: hci_bcm: improve use of gpios API

From	Marcel Holtmann <marcel@holtmann.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Bluetooth: hci_bcm: improve use of gpios API
Date	2015-08-12 16:40 +0200
Message-ID	<pWFm9-7bv-3@gated-at.bofh.it> (permalink)
References	<pWykF-5Aj-5@gated-at.bofh.it> <pWyE2-5X6-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Uwe,

> devm_gpiod_get currently has an optional parameter to set initial
> direction and value for the requested gpio. Make use of this to simplify
> the driver and make it not fail to build when this parameter is made
> mandatory (which is scheduled for 4.3-rc1).
> 
> Moreover use the _optional variant of devm_gpiod_get to simplify error
> handling (which also gets more strict for free).
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> this is needed on top of commit 0395ffc1ee05 ("Bluetooth: hci_bcm: Add
> PM for BCM devices") incombination with b17d1bf16cc7 ("gpio: make flags
> mandatory for gpiod_get functions") which is currently sitting in next.
> 
> Stephen fixed it up with a simpler patch, which works fine, but doesn't
> benefit from the nice things devm_gpiod_get et al offer.

patch has been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the gpio tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-08-12 09:10 +0200
  [PATCH] Bluetooth: hci_bcm: improve use of gpios API Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-12 09:30 +0200
    Re: [PATCH] Bluetooth: hci_bcm: improve use of gpios API Stephen Rothwell <sfr@canb.auug.org.au> - 2015-08-12 10:20 +0200
    Re: [PATCH] Bluetooth: hci_bcm: improve use of gpios API Marcel Holtmann <marcel@holtmann.org> - 2015-08-12 16:40 +0200

csiph-web