Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205971

Re: [PATCH 11/20] regmap: _regmap_raw_read: Add handling of busses without bus->read()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 12, 2015 at 12:12:36PM +0200, Markus Pargmann wrote:

> +	/*
> +	 * There are busses that do not have a read function as it is optional.
> +	 * Use their reg_read function instead if the requested number of bytes
> +	 * is correct.
> +	 */
> +	if (!map->bus->read) {
> +		/*
> +		 * bus_reg_read() does not support reading values that are not
> +		 * exactly the size of format.val_bytes
> +		 */
> +		if (val_len != map->format.val_bytes)
> +			return -EINVAL;
> +		return _regmap_bus_reg_read(map, reg, val);
> +	}

No, this makes no sense - if the device doesn't have a read operation
then it doesn't support a raw data stream and hence can't support raw
access sensibly.  Callers that want to access a lot of registers at once
without knowing what the wire format for the device is should be using
the bulk or multi interfaces.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 11/20] regmap: _regmap_raw_read: Add handling of busses without bus->read() Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:20 +0200
  Re: [PATCH 11/20] regmap: _regmap_raw_read: Add handling of busses  without bus->read() Mark Brown <broonie@kernel.org> - 2015-08-12 13:30 +0200
    Re: [PATCH 11/20] regmap: _regmap_raw_read: Add handling of busses  without bus->read() Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 14:40 +0200
      Re: [PATCH 11/20] regmap: _regmap_raw_read: Add handling of busses  without bus->read() Mark Brown <broonie@kernel.org> - 2015-08-15 04:20 +0200

csiph-web