Groups > linux.kernel > #1205969

Re: [PATCH 07/20] regmap: Without bus read() or write(), force use_single_rw

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/20] regmap: Without bus read() or write(), force use_single_rw
Date	2015-08-12 13:20 +0200
Message-ID	<pWCeC-2Kj-21@gated-at.bofh.it> (permalink)
References	<pWBix-1oV-9@gated-at.bofh.it> <pWBiz-1oV-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 12, 2015 at 12:12:32PM +0200, Markus Pargmann wrote:
> The implementation of regmap bus read() and write() methods are
> optional. Therefore we have to handle busses which do not have these
> functions. If raw read() and write() is not supported we have to use
> reg_read and reg_write always.
> 
> This patch sets use_single_rw if read() or write() is not set.

> -	map->use_single_rw = config->use_single_rw;
> +	map->use_single_rw = config->use_single_rw || !bus->read || !bus->write;

This doesn't follow, we should be able to support write only or read
only buses.  There are some out there.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 07/20] regmap: Without bus read() or write(), force use_single_rw Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:20 +0200
  Re: [PATCH 07/20] regmap: Without bus read() or write(), force use_single_rw Daniel Kurtz <djkurtz@chromium.org> - 2015-08-12 12:40 +0200
    Re: [PATCH 07/20] regmap: Without bus read() or write(), force  use_single_rw Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:50 +0200
  Re: [PATCH 07/20] regmap: Without bus read() or write(), force  use_single_rw Mark Brown <broonie@kernel.org> - 2015-08-12 13:20 +0200

csiph-web