Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1205994

Re: [PATCH v1 3/3] device property: attach 'else if' to the proper 'if'

From Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v1 3/3] device property: attach 'else if' to the proper 'if'
Date 2015-08-12 14:00 +0200
Message-ID <pWCRm-3tG-55@gated-at.bofh.it> (permalink)
References <pVYAx-3Ki-3@gated-at.bofh.it> <pVYAx-3Ki-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Aug 10, 2015 at 07:56:48PM +0300, Andy Shevchenko wrote:
> Obviously in the current place the 'else' keyword is redundant, though it seems
> quite correct when we check if nval is in allowed range.
> 
> Reattach the condition branch there.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

When the leftovers you mentioned are dropped you can add my,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v1 3/3] device property: attach 'else if' to the proper 'if' Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-08-10 19:00 +0200
  Re: [PATCH v1 3/3] device property: attach 'else if' to the proper  'if' Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-08-10 19:10 +0200
  Re: [PATCH v1 3/3] device property: attach 'else if' to the proper  'if' Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-08-12 14:00 +0200

csiph-web