Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205988
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 13/20] regmap: regmap max_raw_io getter function |
| Date | 2015-08-12 14:00 +0200 |
| Message-ID | <pWCRk-3tG-23@gated-at.bofh.it> (permalink) |
| References | <pWBix-1oV-9@gated-at.bofh.it> <pWBiz-1oV-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Wed, Aug 12, 2015 at 12:12:38PM +0200, Markus Pargmann wrote:
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Your changelog doesn't mention why anything would reasonably want to use
this and...
> +size_t regmap_get_raw_io_max(struct regmap *map)
> +{
> + return map->max_raw_io;
> +}
> +EXPORT_SYMBOL_GPL(regmap_get_raw_io_max);
> +
> +/**
> + * regmap_get_raw_read_max - Get the maximum size we can read
> + *
> + * @map: Map to check.
> + */
...it is adding two functions which don't seem very symmetrically named.
> @@ -441,6 +441,8 @@ int regmap_get_max_register(struct regmap *map);
> int regmap_get_reg_stride(struct regmap *map);
> int regmap_async_complete(struct regmap *map);
> bool regmap_can_raw_write(struct regmap *map);
> +size_t regmap_get_raw_write_max(struct regmap *map);
> +size_t regmap_get_raw_io_max(struct regmap *map);
Do we want stubs here?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 13/20] regmap: regmap max_raw_io getter function Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:20 +0200
Re: [PATCH 13/20] regmap: regmap max_raw_io getter function Mark Brown <broonie@kernel.org> - 2015-08-12 14:00 +0200
Re: [PATCH 13/20] regmap: regmap max_raw_io getter function Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 15:00 +0200
csiph-web