Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205980
| From | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support |
| Date | 2015-08-12 13:50 +0200 |
| Message-ID | <pWCHE-3ic-7@gated-at.bofh.it> (permalink) |
| References | <pVW5I-iZ-3@gated-at.bofh.it> <pVW5I-iZ-17@gated-at.bofh.it> <pWBLA-1Xg-15@gated-at.bofh.it> <pWCxY-36M-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/08/15 12:32, maitysanchayan@gmail.com wrote: > Hello, > > On 15-08-12 11:41:55, Srinivas Kandagatla wrote: >> >Hi Sanchayan, >> > >> >Please run checkpatch before you send the patch next time. >> >Look at Documentation/SubmittingPatches for more details. >> > >> >WARNING: line over 80 characters >> >#225: FILE: drivers/nvmem/vf610-ocotp.c:174: >> >+ ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG); >> > >> >WARNING: line over 80 characters >> >#237: FILE: drivers/nvmem/vf610-ocotp.c:186: >> >+ ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG); >> > >> >WARNING: line over 80 characters >> >#244: FILE: drivers/nvmem/vf610-ocotp.c:193: >> >+ writel(OCOTP_CTRL_ERROR, ocotp->base + OCOTP_CTRL_CLR); >> > > I had. However splitting these lines seemed odd. Will split and fix. > Just get the base to a local variable, which should make it look neat and this will avoid de-referencing the octop in the all the time in loop. --srini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v8 0/4] Implement OCOTP driver for Vybrid using NVMEM Sanchayan Maity <maitysanchayan@gmail.com> - 2015-08-10 16:20 +0200
[PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support Sanchayan Maity <maitysanchayan@gmail.com> - 2015-08-10 16:20 +0200
Re: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 17:00 +0200
Re: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-12 12:50 +0200
Re: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support maitysanchayan@gmail.com - 2015-08-12 13:40 +0200
Re: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-12 13:50 +0200
[PATCH v8 1/4] clk: clk-vf610: Add clock for Vybrid OCOTP controller Sanchayan Maity <maitysanchayan@gmail.com> - 2015-08-10 16:20 +0200
csiph-web