Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205961

Re: [PATCH v2 1/4] thermal: power_allocator: relax the requirement of a sustainable_power in tzp

Show all headers | View raw

Hi Javi,

One Tiny nit below...

On Tue, Aug 11, 2015 at 6:21 PM, Javi Merino <javi.merino@arm.com> wrote:
> The power allocator governor currently requires that a sustainable power
> is passed as part of the thermal zone's thermal zone parameters.  If
> that parameter is not provided, it doesn't register with the thermal
> zone.
>
> While this parameter is strongly recommended for optimal performance, it
> doesn't need to be mandatory.  Relax the requirement and allow the
> governor to bind to thermal zones that don't provide it by estimating it
> from the cooling devices' power model.
>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Signed-off-by: Javi Merino <javi.merino@arm.com>
> ---

[snip]

> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -997,6 +997,34 @@ int power_actor_get_max_power(struct thermal_cooling_device *cdev,
>  }
>
>  /**
> + * power_actor_get_min_power() - get the mainimum power that a cdev can consume
> + * @cdev:      pointer to &thermal_cooling_device
> + * @tz:                a valid thermal zone device pointer
> + * @min_power: pointer in which to store the minimum power
> + *
> + * Calculate the minimum power consumption in milliwats that the
                                                 ^
                                                 milliwatts

Thanks,
-Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] thermal: remove power allocator from list of default  governors Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-04 18:40 +0200
  Re: [PATCH] thermal: remove power allocator from list of default  governors Javi Merino <javi.merino@arm.com> - 2015-08-05 10:40 +0200
    Re: [PATCH] thermal: remove power allocator from list of default  governors Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2015-08-05 18:30 +0200
    Re: [PATCH] thermal: remove power allocator from list of default  governors Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-05 18:40 +0200
      Re: [PATCH] thermal: remove power allocator from list of default  governors Eduardo Valentin <edubezval@gmail.com> - 2015-08-05 21:00 +0200
        Re: [PATCH] thermal: remove power allocator from list of default  governors Javi Merino <javi.merino@arm.com> - 2015-08-06 10:40 +0200
          [PATCH 3/3] thermal: power_allocator: exit early if there are no cooling devices Javi Merino <javi.merino@arm.com> - 2015-08-10 18:10 +0200
          [PATCH 2/3] thermal: power_allocator: relax the requirement of two passive trip points Javi Merino <javi.merino@arm.com> - 2015-08-10 18:10 +0200
          [PATCH 0/3] Let the power allocator thermal governor run on any thermal zone Javi Merino <javi.merino@arm.com> - 2015-08-10 18:10 +0200
            [PATCH 1/3] thermal: power_allocator: relax the requirement of a sustainable_power in tzp Javi Merino <javi.merino@arm.com> - 2015-08-10 18:10 +0200
            [PATCH v2 0/4] Let the power allocator thermal governor run on any thermal zone Javi Merino <javi.merino@arm.com> - 2015-08-11 12:30 +0200
              [PATCH v2 1/4] thermal: power_allocator: relax the requirement of a sustainable_power in tzp Javi Merino <javi.merino@arm.com> - 2015-08-11 12:30 +0200
                Re: [PATCH v2 1/4] thermal: power_allocator: relax the requirement of a sustainable_power in tzp Punit Agrawal <punit.agrawal@arm.com> - 2015-08-11 15:50 +0200
                Re: [PATCH v2 1/4] thermal: power_allocator: relax the requirement  of a sustainable_power in tzp Javi Merino <javi.merino@arm.com> - 2015-08-11 19:40 +0200
                Re: [PATCH v2 1/4] thermal: power_allocator: relax the requirement of  a sustainable_power in tzp Daniel Kurtz <djkurtz@chromium.org> - 2015-08-12 13:10 +0200
              [PATCH v2 3/4] thermal: power_allocator: don't require tzp to be present for the thermal zone Javi Merino <javi.merino@arm.com> - 2015-08-11 12:30 +0200
              [PATCH v2 2/4] thermal: power_allocator: relax the requirement of two passive trip points Javi Merino <javi.merino@arm.com> - 2015-08-11 12:30 +0200
                Re: [PATCH v2 2/4] thermal: power_allocator: relax the requirement of  two passive trip points Daniel Kurtz <djkurtz@chromium.org> - 2015-08-12 13:20 +0200
                Re: [PATCH v2 2/4] thermal: power_allocator: relax the requirement  of two passive trip points Javi Merino <javi.merino@arm.com> - 2015-08-12 18:50 +0200
              [PATCH v2 4/4] thermal: power_allocator: exit early if there are no cooling devices Javi Merino <javi.merino@arm.com> - 2015-08-11 12:30 +0200
              [PATCH v3 1/4] thermal: power_allocator: relax the requirement of a sustainable_power in tzp Javi Merino <javi.merino@arm.com> - 2015-08-17 19:40 +0200
              [PATCH v3 0/4] Let the power allocator thermal governor run on any thermal zone Javi Merino <javi.merino@arm.com> - 2015-08-17 19:40 +0200
                [PATCH v3 4/4] thermal: power_allocator: exit early if there are no cooling devices Javi Merino <javi.merino@arm.com> - 2015-08-17 19:40 +0200
                [PATCH v3 2/4] thermal: power_allocator: relax the requirement of two passive trip points Javi Merino <javi.merino@arm.com> - 2015-08-17 19:40 +0200
                [PATCH v3 3/4] thermal: power_allocator: don't require tzp to be present for the thermal zone Javi Merino <javi.merino@arm.com> - 2015-08-17 19:40 +0200

csiph-web