Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205953

Re: [RFCv5 PATCH 20/46] sched: Relocated get_cpu_usage() and change return type

Show all headers | View raw

On Tue, Jul 07, 2015 at 07:24:03PM +0100, Morten Rasmussen wrote:
> +static unsigned long get_cpu_usage(int cpu)
> +{
> +	int sum;
> +	unsigned long usage = cpu_rq(cpu)->cfs.utilization_load_avg;
> +	unsigned long blocked = cpu_rq(cpu)->cfs.utilization_blocked_avg;
> +	unsigned long capacity_orig = capacity_orig_of(cpu);
> +
> +	sum = usage + blocked;
> +
> +	if (sum >= capacity_orig)
> +		return capacity_orig;
> +
> +	return sum;
> +}

Should sum then not also be unsigned long?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFCv5 PATCH 20/46] sched: Relocated get_cpu_usage() and change  return type Peter Zijlstra <peterz@infradead.org> - 2015-08-12 13:00 +0200
  Re: [RFCv5 PATCH 20/46] sched: Relocated get_cpu_usage() and change  return type Morten Rasmussen <morten.rasmussen@arm.com> - 2015-08-12 16:40 +0200

csiph-web