Groups > linux.kernel > #1205738

Re: [RFCv5 PATCH 11/46] sched: Remove blocked load and utilization contributions of dying tasks

From	Morten Rasmussen <morten.rasmussen@arm.com>
Newsgroups	linux.kernel
Subject	Re: [RFCv5 PATCH 11/46] sched: Remove blocked load and utilization contributions of dying tasks
Date	2015-08-12 11:10 +0200
Message-ID	<pWAcQ-8hY-47@gated-at.bofh.it> (permalink)
References	<pJFN0-Ef-15@gated-at.bofh.it> <pJFN2-Ef-75@gated-at.bofh.it> <pWg4p-3PJ-13@gated-at.bofh.it> <pWjbY-8hI-37@gated-at.bofh.it> <pWlx7-3nb-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 11, 2015 at 07:23:44PM +0200, Peter Zijlstra wrote:
> On Tue, Aug 11, 2015 at 03:58:48PM +0100, Morten Rasmussen wrote:
> > On Tue, Aug 11, 2015 at 01:39:27PM +0200, Peter Zijlstra wrote:
> 
> > > You add extra code the hot dequeue path for something that 'never'
> > > happens. We have the sched_class::task_dead call for that.
> > 
> > I don't mind using sched_class::task_dead() instead. The reason why I
> > didn't go that way is that we have to retake the rq->lock or mess with
> > cfs_rq::removed_load instead of just not adding the utilization in
> > the first place when we have the rq->lock.
> > 
> > Anyway, it is probably redundant by now. I will check Yuyang's code to
> > see if he already fixed this problem.
> 
> He did, he used the removed_load stuff, same as migration does.

Nice. One less patch to worry about :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFCv5 PATCH 11/46] sched: Remove blocked load and utilization  contributions of dying tasks Peter Zijlstra <peterz@infradead.org> - 2015-08-11 13:40 +0200
  Re: [RFCv5 PATCH 11/46] sched: Remove blocked load and utilization  contributions of dying tasks Morten Rasmussen <morten.rasmussen@arm.com> - 2015-08-11 17:00 +0200
    Re: [RFCv5 PATCH 11/46] sched: Remove blocked load and utilization  contributions of dying tasks Peter Zijlstra <peterz@infradead.org> - 2015-08-11 19:30 +0200
      Re: [RFCv5 PATCH 11/46] sched: Remove blocked load and utilization  contributions of dying tasks Morten Rasmussen <morten.rasmussen@arm.com> - 2015-08-12 11:10 +0200

csiph-web