Groups > linux.kernel > #1204748

Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled
Date	2015-08-11 06:50 +0200
Message-ID	<pW9FE-2Yw-5@gated-at.bofh.it> (permalink)
References	<pPhyh-60f-3@gated-at.bofh.it> <pPhyh-60f-1@gated-at.bofh.it> <pPsDp-578-21@gated-at.bofh.it> <pW9mi-2Cq-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/10/2015 09:28 PM, Daniel Kurtz wrote:
> Hi Guenter, Matthias,
>
> On Fri, Jul 24, 2015 at 1:37 AM, Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
>> On Thursday, July 23, 2015 01:49:11 PM Eddie Huang wrote:
>>> From: Greta Zhang <greta.zhang@mediatek.com>
>>>
>>> Without .shutdown(), watchdog might reset the system during power off.
>>> For example, if watchdog's timeout is set to 30s, then it is reset to
>>> zero by mtk_wdt_ping(). During power off, no app will ping watchdog,
>>> but watchdog is still running and may trigger reset.
>>>
>>> Signed-off-by: Greta Zhang <greta.zhang@mediatek.com>
>>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
>>> ---
>>>   drivers/watchdog/mtk_wdt.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>
>> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> is the plan to land these two patches via Guenter's watchdog tree [0]?
> [0] git://www.linux-watchdog.org/linux-watchdog.git
>
That is Wim's tree, and Wim is the maintainer ;-).

I have the patches queued in my tree [1], and I plan to send a pull request
to Wim this week or early next week.

Guenter

---
[1] https://git.kernel.org/cgit/linux/kernel/git/groeck/linux-staging.git/log/?h=watchdog-next

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt  if enabled Daniel Kurtz <djkurtz@chromium.org> - 2015-08-11 06:30 +0200
  Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable  wdt if enabled Guenter Roeck <linux@roeck-us.net> - 2015-08-11 06:50 +0200
    Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt  if enabled Daniel Kurtz <djkurtz@chromium.org> - 2015-08-11 09:40 +0200

csiph-web