Groups > linux.kernel > #1204715

Re: [PATCHv2 6/8] serial: imx: add runtime pm support

Path	csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!bofh.it!news.nic.it!robomod
From	Fabio Estevam <festevam@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 6/8] serial: imx: add runtime pm support
Date	Tue, 11 Aug 2015 05:10:01 +0200
Message-ID	<pW86R-SW-1@gated-at.bofh.it> (permalink)
References	<pW6HL-75p-5@gated-at.bofh.it> <pW6HL-75p-11@gated-at.bofh.it>
X-Original-To	Eduardo Valentin <edubezval@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wNarV3ucEvUd8nUrZN4HTktcMc2mlVAxVornoZtVBCY=; b=XSsOvdaiLgphe7IzJAS8rukoVayKg6d6rXupxJO8RfBuSmREoS0JGdPaxxs6pNi/ZP lik3zjE2dWJ0hT05xFful7GDBEOyPsxu17F3EZAq6qs2786l0OTeE7Mmo5+1N+4m22gM ZwvMzx9UPTH+GWuaqNUmNkHdqbh8O0uDk0yEbahZ6ED9L979/DMHZ4pHBacLwVyml8xC al2QM1aBo/d92PMsqGbzSTr1vQ1PF7iGXEtOD3YNcFHWGbYSB1MwWOpMc6IFPULHKAB1 cUMdQUPbQrG81PEfxMIuh5T5hO0URa0rkVRbFi38GiIrpkyhO7GUYe2h+ssM1GJoFk8p r+zw==
MIME-Version	1.0
X-Received	by 10.182.241.163 with SMTP id wj3mr13608748obc.28.1439262178558; Mon, 10 Aug 2015 20:02:58 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Sascha Hauer <s.hauer@pengutronix.de>, Linux PM <linux-pm@vger.kernel.org>, "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 11 Aug 2015 00:02:58 -0300
X-Original-Message-ID	<CAOMZO5CCAd3_nYw2M1qPEevzJaymMi0oAn6FqGih3HbhvrYc9A@mail.gmail.com>
X-Original-References	<1439256949-626-1-git-send-email-edubezval@gmail.com> <1439256949-626-7-git-send-email-edubezval@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1204715

Show key headers only | View raw

On Mon, Aug 10, 2015 at 10:35 PM, Eduardo Valentin <edubezval@gmail.com> wrote:

>  static int imx_poll_get_char(struct uart_port *port)
>  {
> -       if (!(readl_relaxed(port->membase + USR2) & USR2_RDR))
> -               return NO_POLL_CHAR;
> +       int ret;
> +
> +       pm_runtime_get_sync(sport->dev);
> +       if (!(readl_relaxed(port->membase + USR2) & USR2_RDR)) {
> +               ret = NO_POLL_CHAR;
> +               goto mark_last;
> +       }
>
> -       return readl_relaxed(port->membase + URXD0) & URXD_RX_DATA;
> +       ret = readl_relaxed(port->membase + URXD0) & URXD_RX_DATA;
> +
> +mark_last:
> +       pm_runtime_mark_last_busy(sport->dev);
> +       pm_runtime_put_autosuspend(sport->dev);

You should return ret here.

> +static int serial_imx_runtime_resume(struct device *dev)
> +{
> +       struct imx_port *sport = dev_get_drvdata(dev);
> +
> +       clk_enable(sport->clk_per);

clk_enable() may fail.

> +       clk_enable(sport->clk_ipg);

Same here.

> @@ -2096,6 +2212,8 @@ static int imx_serial_port_resume(struct device *dev)
>         struct platform_device *pdev = to_platform_device(dev);
>         struct imx_port *sport = platform_get_drvdata(pdev);
>
> +       clk_prepare_enable(sport->clk_per);

clk_prepare_enable() may fail.

> +       clk_prepare_enable(sport->clk_ipg);

Ditto.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHv2 0/8] serial: imx: rework pm support and add runtime pm Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200
  [PATCHv2 2/8] serial: imx: introduce serial_imx_enable_wakeup() Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200
  [PATCHv2 6/8] serial: imx: add runtime pm support Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200
    Re: [PATCHv2 6/8] serial: imx: add runtime pm support Fabio Estevam <festevam@gmail.com> - 2015-08-11 05:10 +0200
      Re: [PATCHv2 6/8] serial: imx: add runtime pm support Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 19:00 +0200
    Re: [PATCHv2 6/8] serial: imx: add runtime pm support Kevin Hilman <khilman@kernel.org> - 2015-08-12 21:40 +0200
  [PATCHv2 8/8] serial: imx: use SET_*SYSTEM_PM_OPS helper functions Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200
  [PATCHv2 1/8] serial: imx: remove unbalanced clk_prepare Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200
  [PATCHv2 7/8] serial: imx: add pm_qos request Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200
  [PATCHv2 4/8] serial: imx: save and restore context in the suspend path Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200
  [PATCHv2 5/8] serial: imx: add a flag to indicate we are in the suspend path Eduardo Valentin <edubezval@gmail.com> - 2015-08-11 03:40 +0200

csiph-web