Groups > linux.kernel > #1204695

Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling with '<' and '>' key

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling with '<' and '>' key
Date	2015-08-11 04:20 +0200
Message-ID	<pW7kt-8aE-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <pVwbg-3k0-9@gated-at.bofh.it> <pVwXD-4uV-5@gated-at.bofh.it> <pVXEv-2ob-47@gated-at.bofh.it> <pW43f-3br-9@gated-at.bofh.it> <pW4cW-3oX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnaldo,

On Mon, Aug 10, 2015 at 07:58:22PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Aug 11, 2015 at 12:46:03AM +0200, Jiri Olsa escreveu:
> > On Mon, Aug 10, 2015 at 12:50:04PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Sun, Aug 09, 2015 at 01:21:39PM +0200, Jiri Olsa escreveu:
> > > > On Sun, Aug 09, 2015 at 07:35:42PM +0900, Namhyung Kim wrote:
> > > > > Jiri said that it'd be more eye-friendly if it can move by column
> > > > > widths.  So change the keys to do it rather than jumping 10 characters.
> > > > > Also add ',' and '.' keys which reside same position in the keyboard to
> > > > > move by 1 characters.
> > > > 
> > > > I like it ;-)
> > > 
> > > Humm, I don't, its not natural, I doubt anyone will think about using ,
> > > and . to move by one character right/left, ditto for <>, I think we
> > > should just recover <- and -> (left and right arrows) for navigation,
> > > leave ENTER to be what -> was doing and esc for what <- does, in fact it
> > > is already like that.
> > 
> > I would ;-) anyway I also think arrows are the best, but I thought we
> > dont want to break existing interface much
> 
> In this case I think we can, enter and esc are really well know keys for
> entering and escaping from a place, and we have them working forever
> doing that, its just that at some time I used <- as an alias for ESC and
> -> as alias for ENTER.
> 
> I.e. for people using ESC and ENTER, this will not be noticed :-)

Yes, but I guess many people use arrow keys more than ESC and ENTER
since we use up/down arrow keys anyway.  I do want to use left/right
arrow for scrolling, but I'm afraid that it'll bother existing users..

Thanks,
Namhyung


>  
> > > Probably using shift or control or alt + <- -> for moving one column at
> > > at time is enough, but humm, is there value in that?
> > 
> > it'd really help for perf mem output, which is quite wide.. and we probably
> > have more wide outputs, or users with narrow terminals ;-)
> 
> I'm not going against horizontal scrolling, it is needed, sure thing,
> its surprising we are doing this only now. What I am asking is this fine
> scrolling of one column per <- or -> keypress, but I really need to try
> it with things like 'perf mem', I thought that when you pressed '>', in
> this patch, it would move entire sort key columns, not just one vertical
> column one character wide, right?
> 
> - Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] perf hists browser: Support horizontal scrolling with '<' and '>' key Namhyung Kim <namhyung@kernel.org> - 2015-08-09 10:30 +0200
  [PATCH v2 2/2] perf hists browser: Support horizontal scrolling for callchains Namhyung Kim <namhyung@kernel.org> - 2015-08-09 10:30 +0200
  Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Jiri Olsa <jolsa@redhat.com> - 2015-08-09 11:40 +0200
    Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Namhyung Kim <namhyung@kernel.org> - 2015-08-09 12:40 +0200
      Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Jiri Olsa <jolsa@redhat.com> - 2015-08-09 13:30 +0200
        Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-10 18:00 +0200
          Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Jiri Olsa <jolsa@redhat.com> - 2015-08-11 00:50 +0200
            Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-11 01:00 +0200
              Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Jiri Olsa <jolsa@redhat.com> - 2015-08-11 01:10 +0200
                Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-11 01:20 +0200
                Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Jiri Olsa <jolsa@redhat.com> - 2015-08-11 01:20 +0200
                Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-11 23:00 +0200
                Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Namhyung Kim <namhyung@kernel.org> - 2015-08-12 08:00 +0200
                Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Jiri Olsa <jolsa@redhat.com> - 2015-08-12 11:20 +0200
                Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-12 15:20 +0200
                Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Namhyung Kim <namhyung@kernel.org> - 2015-08-11 04:30 +0200
              Re: [PATCH v2 1/2] perf hists browser: Support horizontal scrolling  with '<' and '>' key Namhyung Kim <namhyung@kernel.org> - 2015-08-11 04:20 +0200

csiph-web