Groups > linux.kernel > #1204712

Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons
Date	2015-08-11 05:00 +0200
Message-ID	<pW7Xb-sj-9@gated-at.bofh.it> (permalink)
References	<pUlKV-7ry-3@gated-at.bofh.it> <pUm4h-7Vg-3@gated-at.bofh.it> <pUrx0-7uB-27@gated-at.bofh.it> <pUx9o-7jm-23@gated-at.bofh.it> <pUyyt-L1-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 06, 2015 at 11:55:29AM -0700, Joe Perches wrote:
> On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> > On Thu, Aug 06, 2015 at 11:20:44AM +0000, Chen, Yu C wrote:
> []
> > > Is it ok to keep these codes and add comments like:
> 
> It's your code Yu, do whatever you think appropriate.
> 
> > > /*
> > >  * When a button(power button/volume button/home button) is 
> > >  * pressed down or released, different ACPI notification codes 
> > >  * will be generated. We can distinguish different event code 
> > >  * and value of buttons by these notification codes, then pass
> > >  * (EV_KEY, event code(key_code), value(pressed)) to input layer.
> > >  */
> > 
> > The commentary is useful regardless. However, I suspect Joe was
> > referring to the approach pairing the PRESS and RELEASE cases?
> > 
> 
> True.
> 
> btw Darren, your computer's email time setting seems off.

Nothing gets past kernel devs! Corporate firewall broke ntp for Linux VM from
where I sent this, didn't notice until too late.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons Chen Yu <yu.c.chen@intel.com> - 2015-08-06 07:20 +0200
  Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3  buttons Joe Perches <joe@perches.com> - 2015-08-06 07:40 +0200
    Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3  buttons "Chen, Yu C" <yu.c.chen@intel.com> - 2015-08-06 13:30 +0200
      Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3  buttons Joe Perches <joe@perches.com> - 2015-08-06 17:00 +0200
      Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3  buttons Darren Hart <dvhart@infradead.org> - 2015-08-06 19:30 +0200
        Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3  buttons Joe Perches <joe@perches.com> - 2015-08-06 21:00 +0200
          Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3  buttons Darren Hart <dvhart@infradead.org> - 2015-08-11 05:00 +0200
        Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3  buttons "Chen, Yu C" <yu.c.chen@intel.com> - 2015-08-07 10:00 +0200

csiph-web