Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204637

Re: [PATCH] sched: ensure a task has a non-normalized vruntime when returning back to cfs

Show all headers | View raw

On Mon, Aug 10, 2015 at 02:14:07PM +0200, Peter Zijlstra wrote:
> On Mon, Aug 10, 2015 at 06:02:55PM +0900, byungchul.park@lge.com wrote:
> > From: Byungchul Park <byungchul.park@lge.com>
> > 
> > current code ensures a task has a normalized vruntime when switching off
> > from fair class, but it does not ensure the task has a non-normalized
> > vruntime when switching back to the fair class.
> > 
> > this is an example breaking this consistency.
> > 
> > 1. a task is in fair class and !queue
> > 2. change its class to rt class (still !queue)
> > 3. change its class to fair class again (stll !queue)
> 
> Just curious, did you manage to trigger this in practise or did you find
> it through code inspection only?

hello,

not only through code inspection, but also checked it through gdb debugger.
when returning back to fair class (step 3), vruntime was still normalized.
more exactly, it has a very large value which means negative value.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sched: ensure a task has a non-normalized vruntime when returning back to cfs byungchul.park@lge.com - 2015-08-10 11:10 +0200
  Re: [PATCH] sched: ensure a task has a non-normalized vruntime when  returning back to cfs Peter Zijlstra <peterz@infradead.org> - 2015-08-10 14:20 +0200
    Re: [PATCH] sched: ensure a task has a non-normalized vruntime when  returning back to cfs Byungchul Park <byungchul.park@lge.com> - 2015-08-11 01:40 +0200
      Re: [PATCH] sched: ensure a task has a non-normalized vruntime when  returning back to cfs Byungchul Park <byungchul.park@lge.com> - 2015-08-11 02:10 +0200
  [tip:sched/core] sched:   Ensure a task has a non-normalized vruntime when returning back to CFS tip-bot for Byungchul Park <tipbot@zytor.com> - 2015-08-12 14:40 +0200

csiph-web