Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204507

Re: [PATCH 1/4] selftests: vm: Fix mlock2-tests for 32-bit architectures

Show all headers | View raw

On 08/07/2015 07:44 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> According to Documentation/vm/pagemap.txt, the /proc/pid/pagemap file
> contains one 64-bit value for each virtual page. The test code relies
> on the size of unsigned long being 64-bit, which breaks the test when
> run on 32-bit architectures. Use a uint64_t to store values read from
> the file instead, so that it works irrespective of the architecture's
> word size.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---

Looks good to me. Andrew! Would you like me to take this patch
and the other two in this series through kselftest git?

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] selftests: vm: Fix mlock2-tests for 32-bit architectures Thierry Reding <thierry.reding@gmail.com> - 2015-08-07 15:50 +0200
  Re: [PATCH 1/4] selftests: vm: Fix mlock2-tests for 32-bit architectures Shuah Khan <shuahkh@osg.samsung.com> - 2015-08-10 21:30 +0200

csiph-web