Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204497

Re: [PATCH] extcon: add index increment in find_cable_index_by_name

Show all headers | View raw

Never mind...

This is already fixed by commit be052cc8 in mainline.

Sorry for the noise.
 -- Tim

On 08/10/2015 10:44 AM, Tim Bird wrote:
> This fixes a bug introduced by commit 73b6ecdb93e8 ("extcon: Redefine the
> unique id of supported external connectors without 'enum extcon' type")
> which introduced an infinite loop in find_cable_index_by_name.  That commit
> converted the scan from a for loop to a while, but did not increment
> 'i' anywhere in the loop.  If the loop index is not incremented, the
> function never exits.
> 
> This function can never work correctly without this fix.
> 
> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
> ---
>  drivers/extcon/extcon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index dda1e62..734a9b1 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -138,6 +138,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
>  			id = i;
>  			break;
>  		}
> +		i++;
>  	}
>  
>  	if (id == EXTCON_NONE)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] extcon: add index increment in find_cable_index_by_name Tim Bird <tim.bird@sonymobile.com> - 2015-08-10 19:50 +0200
  Re: [PATCH] extcon: add index increment in find_cable_index_by_name Tim Bird <tim.bird@sonymobile.com> - 2015-08-10 21:20 +0200

csiph-web