Groups > linux.kernel > #1203629

Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.

From	Alexander Holler <holler@ahsoftware.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.
Date	2015-08-09 12:50 +0200
Message-ID	<pVwkV-3vB-13@gated-at.bofh.it> (permalink)
References	<pSotA-78K-5@gated-at.bofh.it> <pSotC-78K-67@gated-at.bofh.it> <pV5kK-6Dj-9@gated-at.bofh.it> <pV678-7N8-11@gated-at.bofh.it> <pVuMa-1qG-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 09.08.2015 um 11:00 schrieb NeilBrown:
> On Sat, 8 Aug 2015 12:18:55 +0530 Kishon Vijay Abraham I
> <kishon@ti.com> wrote:
>
>>
>>
>> On Saturday 08 August 2015 11:23 AM, Alexander Holler wrote:
>>> Hello,
>>>
>>> this patch killed the musb-host functionality on my classic Beagleboard (rev
>>> c4). Symptom was that it there was a message I don't remember and the attached
>>> device didn't enumerate anymore (likely because of missing power, but I'm not
>>> sure).
>>>
>>> A simple revert has fixed it, I haven't looked further into the problem.
>>
>> Neil Brown, how was this tested?
>
>
> Well, I have a board with an OMAP3 connected to a twl4030 for USB and I
> noted that it wasn't power-managed properly and when I made that change,
> it was.  I don't recall the exact details
>
> This is probably related to
>
> Commit: 56301df6bcaa ("phy: twl4030-usb: make runtime pm more reliable.")
>
> I certainly only tested with that patch in place.

Cherry-Picking 56301df6bcaa instead of reverting  d1221a608bd did the 
trick too. So it looks like 56301df6bcaa is indeed a prerequisit for 
d1221a608bd.

Therefor I suggest to feed 56301df6bcaa to the stable series (e.g. 
4.1.6) too.

Regards,

Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect  pm_runtime_get_sync() in probe function. Alexander Holler <holler@ahsoftware.de> - 2015-08-08 08:00 +0200
  Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect pm_runtime_get_sync()  in probe function. Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-08 08:50 +0200
    Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect  pm_runtime_get_sync() in probe function. NeilBrown <neil@brown.name> - 2015-08-09 11:10 +0200
      Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect  pm_runtime_get_sync() in probe function. Alexander Holler <holler@ahsoftware.de> - 2015-08-09 12:50 +0200
        Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect  pm_runtime_get_sync() in probe function. NeilBrown <neil@brown.name> - 2015-08-11 10:30 +0200
          Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect  pm_runtime_get_sync() in probe function. Alexander Holler <holler@ahsoftware.de> - 2015-08-11 23:40 +0200
            Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect  pm_runtime_get_sync() in probe function. NeilBrown <neil@brown.name> - 2015-08-12 00:10 +0200
              Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect  pm_runtime_get_sync() in probe function. Felipe Balbi <balbi@ti.com> - 2015-08-12 02:30 +0200

csiph-web