Groups > linux.kernel > #1203495

Re: [PATCH 4.1 076/123] Input: zforce - dont overwrite the stack

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4.1 076/123] Input: zforce - dont overwrite the stack
Date	2015-08-09 00:40 +0200
Message-ID	<pVkWv-3Tb-61@gated-at.bofh.it> (permalink)
References	<pVkD7-3vG-3@gated-at.bofh.it> <pVkD8-3vG-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Greg,

On August 8, 2015 3:09:14 PM PDT, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>4.1-stable review patch.  If anyone has any objections, please let me
>know.

This was a bad patch and its reverted n mainline, please drop.

>
>------------------
>
>From: Oleksij Rempel <external.Oleksij.Rempel@de.bosch.com>
>
>commit 7d01cd261c76f95913c81554a751968a1d282d3a upstream.
>
>If we get a corrupted packet with PAYLOAD_LENGTH > FRAME_MAXSIZE, we
>will silently overwrite the stack.
>
>Signed-off-by: Oleksij Rempel <external.Oleksij.Rempel@de.bosch.com>
>Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>---
> drivers/input/touchscreen/zforce_ts.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>--- a/drivers/input/touchscreen/zforce_ts.c
>+++ b/drivers/input/touchscreen/zforce_ts.c
>@@ -430,7 +430,7 @@ static int zforce_read_packet(struct zfo
> 		goto unlock;
> 	}
> 
>-	if (buf[PAYLOAD_LENGTH] == 0) {
>+	if (buf[PAYLOAD_LENGTH] == 0 || buf[PAYLOAD_LENGTH] > FRAME_MAXSIZE)
>{
> 		dev_err(&client->dev, "invalid payload length: %d\n",
> 			buf[PAYLOAD_LENGTH]);
> 		ret = -EIO;


Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 4.1 076/123] Input: zforce - dont overwrite the stack Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-09 00:20 +0200
  Re: [PATCH 4.1 076/123] Input: zforce - dont overwrite the stack Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-09 00:40 +0200
    Re: [PATCH 4.1 076/123] Input: zforce - dont overwrite the stack Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-10 21:20 +0200

csiph-web