Groups > linux.kernel > #1203919

[PATCH] isdn:remove reverse_bits(), use revbit8()

Path	csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	yalin wang <yalin.wang2010@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] isdn:remove reverse_bits(), use revbit8()
Date	Mon, 10 Aug 2015 11:20:03 +0200
Message-ID	<pVRpp-1Iy-17@gated-at.bofh.it> (permalink)
X-Original-To	isdn@linux-pingi.de, netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; bh=eIBJ0XySeE1c49/jyQs5BbcYz7OEV7Ohi9CnFlENyAI=; b=WvSOK4t5VmBmXX1xN3LEmZG3sae4k8O/e3xqe7QmatPMqUA1czG/AU77T+f/dQeAlX 8wot8Sp5pCgoKOxygdKJUU5xfUt6xb4xVt3xPCfZLeo/Xe05w//tk0wHGpOHutFEhv0q jeNkmPxFos3fhobTRW+H0Rs/jxCykhax8KvCwvnou5fLJw40Gm1m+Y0mtr8izdr0NTmO pAfpr/3krF7TwKxBBCEYkedWr6N/JgEPQL+BrFotVocBhv0PfdbtBhZgEvMtL/s0RFgg e3Pkwc37GNWKCmFALgod6RhT2z5CxiJbXCdJnsKpWKArAkBkdvrdqde0J5cVGuqJAiEh MN/A==
X-Received	by 10.68.253.232 with SMTP id ad8mr43348264pbd.115.1439198161884; Mon, 10 Aug 2015 02:16:01 -0700 (PDT)
Content-Type	text/plain; charset=us-ascii
Content-Transfer-Encoding	7bit
MIME-Version	1.0 (Mac OS X Mail 8.2 \(2098\))
X-Mailer	Apple Mail (2.2098)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	74
Organization	linux.* mail to news gateway
X-Original-Date	Mon, 10 Aug 2015 17:15:57 +0800
X-Original-Message-ID	<48EEE6BC-BAFE-4545-A860-237FBD1E279B@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1203919

Show key headers only | View raw

This change isdn driver, remove reverse_bits() function,
use the generic revbit8() function instead.

Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
 drivers/isdn/mISDN/dsp_audio.c | 22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/drivers/isdn/mISDN/dsp_audio.c b/drivers/isdn/mISDN/dsp_audio.c
index 0602295..bbef98e 100644
--- a/drivers/isdn/mISDN/dsp_audio.c
+++ b/drivers/isdn/mISDN/dsp_audio.c
@@ -13,6 +13,7 @@
 #include <linux/mISDNif.h>
 #include <linux/mISDNdsp.h>
 #include <linux/export.h>
+#include <linux/bitrev.h>
 #include "core.h"
 #include "dsp.h"
 
@@ -137,27 +138,14 @@ static unsigned char linear2ulaw(short sample)
 	return ulawbyte;
 }
 
-static int reverse_bits(int i)
-{
-	int z, j;
-	z = 0;
-
-	for (j = 0; j < 8; j++) {
-		if ((i & (1 << j)) != 0)
-			z |= 1 << (7 - j);
-	}
-	return z;
-}
-
-
 void dsp_audio_generate_law_tables(void)
 {
 	int i;
 	for (i = 0; i < 256; i++)
-		dsp_audio_alaw_to_s32[i] = alaw2linear(reverse_bits(i));
+		dsp_audio_alaw_to_s32[i] = alaw2linear(bitrev8((u8)i));
 
 	for (i = 0; i < 256; i++)
-		dsp_audio_ulaw_to_s32[i] = ulaw2linear(reverse_bits(i));
+		dsp_audio_ulaw_to_s32[i] = ulaw2linear(bitrev8((u8)i));
 
 	for (i = 0; i < 256; i++) {
 		dsp_audio_alaw_to_ulaw[i] =
@@ -176,13 +164,13 @@ dsp_audio_generate_s2law_table(void)
 		/* generating ulaw-table */
 		for (i = -32768; i < 32768; i++) {
 			dsp_audio_s16_to_law[i & 0xffff] =
-				reverse_bits(linear2ulaw(i));
+				bitrev8(linear2ulaw(i));
 		}
 	} else {
 		/* generating alaw-table */
 		for (i = -32768; i < 32768; i++) {
 			dsp_audio_s16_to_law[i & 0xffff] =
-				reverse_bits(linear2alaw(i));
+				bitrev8(linear2alaw(i));
 		}
 	}
 }
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] isdn:remove reverse_bits(), use revbit8()  yalin wang <yalin.wang2010@gmail.com> - 2015-08-10 11:20 +0200
  Re: [PATCH] isdn:remove reverse_bits(), use revbit8()  David Miller <davem@davemloft.net> - 2015-08-10 23:40 +0200
    Re: [PATCH] isdn:remove reverse_bits(), use revbit8()  yalin wang <yalin.wang2010@gmail.com> - 2015-08-11 03:40 +0200

csiph-web