Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1203657

[PATCH v2] staging: wilc1000: Remove pointer and integer comparision

From Chandra S Gorentla <csgorentla@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2] staging: wilc1000: Remove pointer and integer comparision
Date 2015-08-09 17:40 +0200
Message-ID <pVARA-1KR-9@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Removed pointer check with integer; this fixes 'sparse' error -
error: incompatible types for operation (>)
   left side has type unsigned char [usertype] *[usertype] pu8Tail
   right side has type int

Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
---
Changes in v2: Subject line corrected wilc100 -> wilc1000

 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index cc549c2..4ba1ad7 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3471,7 +3471,7 @@ static void Handle_AddBeacon(void *drvHandler, tstrHostIFSetBeacon *pstrSetBeaco
 	*pu8CurrByte++ = ((pstrSetBeaconParam->u32TailLen >> 24) & 0xFF);
 
 	/* Bug 4599 : if tail length = 0 skip copying */
-	if (pstrSetBeaconParam->pu8Tail > 0)
+	if (pstrSetBeaconParam->pu8Tail != NULL)
 		memcpy(pu8CurrByte, pstrSetBeaconParam->pu8Tail, pstrSetBeaconParam->u32TailLen);
 	pu8CurrByte += pstrSetBeaconParam->u32TailLen;
 
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH v2] staging: wilc1000: Remove pointer and integer comparision Chandra S Gorentla <csgorentla@gmail.com> - 2015-08-09 17:40 +0200
  Re: [PATCH v2] staging: wilc1000: Remove pointer and integer  comparision Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-10 06:40 +0200

csiph-web