Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1201928

Re: [PATCH] ARM: Mark ret_fast_syscall as a function

From Nicolas Pitre <nicolas.pitre@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: Mark ret_fast_syscall as a function
Date 2015-08-06 19:40 +0200
Message-ID <pUxj7-7uZ-39@gated-at.bofh.it> (permalink)
References <pMzi2-75l-7@gated-at.bofh.it> <pUwQ1-6WB-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 6 Aug 2015, Drew Richardson wrote:

> On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote:
> > ret_fast_syscall runs when user space makes a syscall. However it
> > needs to be marked as such so the ELF information is correct. Before
> > it was:
> > 
> >    101: 8000f300     0 NOTYPE  LOCAL  DEFAULT    2 ret_fast_syscall
> > 
> > But with this change it correctly shows as:
> > 
> >    101: 8000f300    96 FUNC    LOCAL  DEFAULT    2 ret_fast_syscall
> > 
> > I see this function when using perf to unwind call stacks from kernel
> > space to user space. Without this change I would need to add some
> > special case logic when using the vmlinux ELF information.
> > 
> > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
> 
> I haven't heard any further comments on this, did this get merged and
> I just didn't notice? Or did I forget to add someone?

Most likely that it is so trivial that nobody paid much attention.

FWIW, you can add

Acked-by: Nicolas Pitre <nico@linaro.org>

and submit it here: http://www.arm.linux.org.uk/developer/patches/


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] ARM: Mark ret_fast_syscall as a function Drew Richardson <drew.richardson@arm.com> - 2015-08-06 19:10 +0200
  Re: [PATCH] ARM: Mark ret_fast_syscall as a function Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-08-06 19:40 +0200
    Re: [PATCH] ARM: Mark ret_fast_syscall as a function Drew Richardson <drew.richardson@arm.com> - 2015-08-06 20:00 +0200

csiph-web