Groups > linux.kernel > #1201877

Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation

From	Dave Hansen <dave.hansen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation
Date	2015-08-06 18:10 +0200
Message-ID	<pUvTY-5yr-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <pU81j-483-1@gated-at.bofh.it> <pUnD4-1Ok-13@gated-at.bofh.it> <pUoIP-3l2-25@gated-at.bofh.it> <pUoIP-3l2-23@gated-at.bofh.it> <pUuOf-3M5-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Here's a correction about what we do today, and it's an important point.
 The code I was ripping out in the patch was *really* just for the
XSAVES/compacted case, does *NOT* do anything today since we've disabled
XSAVES.

So perhaps the title here should be:

	[PATCH] x86, fpu: correct XSAVES xstate size calculation

/* Option 1, what we have today */

	if (!cpu_has_xsaves) {
		cpuid(0xD0, 0, &total_blob_size, ...);
		return;
	}
	/*
	 * This breaks if offset[i]+size[i] != offset[i+1]
	 * or if alignment is in play.  Silly hardware breaks
	 * this today.
	 */
	for (i = 0; i < nr_xstates; i++) {
		if (!enabled_xstate(i))
			continue;
		total_blob_size += xstate_sizes[i];
	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Ingo Molnar <mingo@kernel.org> - 2015-08-05 12:40 +0200
  Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Dave Hansen <dave@sr71.net> - 2015-08-05 16:40 +0200
    Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Ingo Molnar <mingo@kernel.org> - 2015-08-06 09:20 +0200
      Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Ingo Molnar <mingo@kernel.org> - 2015-08-06 10:30 +0200
        Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Ingo Molnar <mingo@kernel.org> - 2015-08-06 10:30 +0200
        Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Dave Hansen <dave@sr71.net> - 2015-08-06 17:00 +0200
          Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Dave Hansen <dave.hansen@linux.intel.com> - 2015-08-06 18:10 +0200
          Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Ingo Molnar <mingo@kernel.org> - 2015-08-08 11:20 +0200
      Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Dave Hansen <dave@sr71.net> - 2015-08-06 19:20 +0200
        Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Ingo Molnar <mingo@kernel.org> - 2015-08-08 11:10 +0200
          Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation Dave Hansen <dave@sr71.net> - 2015-08-10 23:20 +0200

csiph-web