Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201729

[PATCH 1/4] DMA: tegra-apb: Remove unused variables

Show all headers | View raw

The callback and callback_param members of the tegra_dma_sg_req structure
are never used. The dma-engine structure, dma_async_tx_descriptor, defines
the same members and these are the ones used by the driver. Therefore,
remove the unused versions from the tegra_dma_sg_req structure.

The half_done member of tegra_dma_channel structure is configured but
never used and so remove it.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/dma/tegra20-apb-dma.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index eaf585e8286b..cf8cff7827f0 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -155,7 +155,6 @@ struct tegra_dma_sg_req {
 	int				req_len;
 	bool				configured;
 	bool				last_sg;
-	bool				half_done;
 	struct list_head		node;
 	struct tegra_dma_desc		*dma_desc;
 };
@@ -203,8 +202,6 @@ struct tegra_dma_channel {
 	/* ISR handler and tasklet for bottom half of isr handling */
 	dma_isr_handler		isr_handler;
 	struct tasklet_struct	tasklet;
-	dma_async_tx_callback	callback;
-	void			*callback_param;
 
 	/* Channel-slave specific configuration */
 	unsigned int slave_id;
@@ -1136,7 +1133,6 @@ static struct dma_async_tx_descriptor *tegra_dma_prep_dma_cyclic(
 		sg_req->ch_regs.apb_seq = apb_seq;
 		sg_req->ch_regs.ahb_seq = ahb_seq;
 		sg_req->configured = false;
-		sg_req->half_done = false;
 		sg_req->last_sg = false;
 		sg_req->dma_desc = dma_desc;
 		sg_req->req_len = len;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] DMA: tegra-apb: Clean-up Jon Hunter <jonathanh@nvidia.com> - 2015-08-06 15:40 +0200
  [PATCH 2/4] DMA: tegra-apb: Avoid unnecessary channel base address calculation Jon Hunter <jonathanh@nvidia.com> - 2015-08-06 15:40 +0200
  [PATCH 3/4] DMA: tegra-apb: Remove unnecessary return statements and variables Jon Hunter <jonathanh@nvidia.com> - 2015-08-06 15:40 +0200
  [PATCH 1/4] DMA: tegra-apb: Remove unused variables Jon Hunter <jonathanh@nvidia.com> - 2015-08-06 15:40 +0200
  [PATCH 4/4] DMA: tegra-apb: Simplify locking for device using global pause Jon Hunter <jonathanh@nvidia.com> - 2015-08-06 15:40 +0200
  Re: [PATCH 0/4] DMA: tegra-apb: Clean-up Jon Hunter <jonathanh@nvidia.com> - 2015-08-18 12:10 +0200

csiph-web