Groups > linux.kernel > #1201757

Re: [PATCH] sysfs: correctly handle short reads on PREALLOC attrs.

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sysfs: correctly handle short reads on PREALLOC attrs.
Date	2015-08-06 16:00 +0200
Message-ID	<pUtSa-2in-15@gated-at.bofh.it> (permalink)
References	<pUfm9-6lp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 06, 2015 at 08:27:55AM +1000, NeilBrown wrote:
> 
> 
> attributes declared with __ATTR_PREALLOC use sysfs_kf_read()
> which ignores the 'count' arg.
> So a 1-byte read request can return more bytes than that.
> 
> This is seen with the 'dash' shell when 'read' is used on
> some 'md' sysfs attributes.
> 
> So only return the 'min' of count and the attribute length.
> 
> Signed-off-by: NeilBrown <neilb@suse.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sysfs: correctly handle short reads on PREALLOC attrs. NeilBrown <neilb@suse.com> - 2015-08-06 00:30 +0200
  Re: [PATCH] sysfs: correctly handle short reads on PREALLOC attrs. Tejun Heo <tj@kernel.org> - 2015-08-06 16:00 +0200

csiph-web