Groups > linux.kernel > #1201687

Re: [PATCH 09/10] Define PERF_PMU_TXN_READ interface

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/10] Define PERF_PMU_TXN_READ interface
Date	2015-08-06 14:20 +0200
Message-ID	<pUsjo-dn-25@gated-at.bofh.it> (permalink)
References	<pQJsu-Qu-3@gated-at.bofh.it> <pQJsv-Qu-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, Jul 26, 2015 at 10:40:37PM -0700, Sukadev Bhattiprolu wrote:
> @@ -3743,7 +3762,13 @@ static u64 perf_event_aggregate(struct perf_event *event, u64 *enabled,
>  	lockdep_assert_held(&event->child_mutex);
>  
>  	list_for_each_entry(child, &event->child_list, child_list) {
> +#if 0
> +		/*
> +		 * TODO: Do we need this read() for group events on PMUs that
> +		 * 	 don't implement PERF_PMU_TXN_READ transactions?
> +		 */
>  		(void)perf_event_read(child, false);
> +#endif
>  		total += perf_event_count(child);
>  		*enabled += child->total_time_enabled;
>  		*running += child->total_time_running;

Aw gawd, I've been an idiot!!

I just realized this is a _CHILD_ loop, not a _SIBLING_ loop !!

We need to flip the loops in perf_read_group(), find attached two
patches that go on top of 1,2,4.

After this you can add the perf_event_read() return value (just fold
patches 6,8) after which you can do patch 10 (which has a broken
Subject fwiw).

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/10] Define PERF_PMU_TXN_READ interface Peter Zijlstra <peterz@infradead.org> - 2015-08-06 14:20 +0200
  Re: [PATCH 09/10] Define PERF_PMU_TXN_READ interface Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2015-08-12 06:20 +0200
    Re: [PATCH 09/10] Define PERF_PMU_TXN_READ interface Peter Zijlstra <peterz@infradead.org> - 2015-08-12 10:50 +0200
      Re: [PATCH 09/10] Define PERF_PMU_TXN_READ interface Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2015-08-13 22:10 +0200
        Re: [PATCH 09/10] Define PERF_PMU_TXN_READ interface Peter Zijlstra <peterz@infradead.org> - 2015-08-13 22:50 +0200

csiph-web