Groups > linux.kernel > #1201660

Re: [PATCHv2 1/2] tty: serial: men_z135_uart.c: Fix race between IRQ and set_termios()

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 1/2] tty: serial: men_z135_uart.c: Fix race between IRQ and set_termios()
Date	2015-08-06 13:30 +0200
Message-ID	<pUrx0-7uB-7@gated-at.bofh.it> (permalink)
References	<pUnD3-1Ok-3@gated-at.bofh.it> <pUrx0-7uB-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/06/2015 03:16 AM, Johannes Thumshirn wrote:
> Fix panic caused by a race between men_z135_intr() and men_z135_set_termios().
> 
> men_z135_intr() and men_z135_set_termios() both hold the struct uart_port::lock
> spinlock, but men_z135_intr() does a spin_lock_irqsave() and
> men_z135_set_termios() does a normal spin_lock(), which can lead to a deadlock
> when an interrupt is called while the lock is being helt by
> men_z135_set_termios().
> 
> This was discovered using a insmod, hardware looppback send/receive, rmmod
> stress test.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/2] tty: serial: men_z135_uart.c: Updates for men_z135_uart Johannes Thumshirn <jthumshirn@suse.de> - 2015-08-06 09:20 +0200
  Re: [PATCHv2 1/2] tty: serial: men_z135_uart.c: Fix race between  IRQ and set_termios() Peter Hurley <peter@hurleysoftware.com> - 2015-08-06 13:30 +0200

csiph-web