Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201650

Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning

Show all headers | View raw

On 06/08/15 10:43, Mark Brown wrote:
> On Wed, Aug 05, 2015 at 05:02:08PM +0100, Srinivas Kandagatla wrote:
>> A recursive lockdep warning occurs if you call regulator_set_voltage()
>> on a load switches that are modelled as regulators with a parent supply as
>> there is no nesting annotation for the rdev->mutex.
>> To avoid this warning, use the unlocked version of the get_voltage().
>
> No, just completely removing the locking is broken - the locking is
> there for a reason!  This needs some lockdep dance, either something

Yes, I totally agree, removing locking would have more regressions.

> like what we have for regmaps with a class per regulator or something

lock_class per regulator makes more sense, I will try to cookup an RFC 
patch.
> more fancy but whatever's going on just hacking out locking to shut up
> warnings from lockdep is clearly not a good idea.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] regulator: Fix recursive mutex lockdep warning Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-05 18:10 +0200
  Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-06 03:40 +0200
    Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-06 09:40 +0200
      Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-06 09:40 +0200
        Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-06 10:00 +0200
  Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Mark Brown <broonie@kernel.org> - 2015-08-06 11:50 +0200
    Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-06 13:10 +0200
      Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-06 13:50 +0200
        Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Mark Brown <broonie@kernel.org> - 2015-08-07 16:20 +0200
      Re: [RFC PATCH] regulator: Fix recursive mutex lockdep warning Mark Brown <broonie@kernel.org> - 2015-08-06 13:50 +0200

csiph-web