Groups > linux.kernel > #1201594

Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]
Date	2015-08-06 11:10 +0200
Message-ID	<pUplv-4re-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <pTknT-7ws-7@gated-at.bofh.it> <pTknV-7ws-41@gated-at.bofh.it> <pU5wu-nj-9@gated-at.bofh.it> <pU8E2-57u-29@gated-at.bofh.it> <pUo66-2mn-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/06/2015, 09:42 AM, Chen Bough wrote:
> I read your attached log and patch, yes, dma memory leak will happen when
> more than one pre_request execute. The method of ++next->cookie is not good,
> your patch seems good, but I still need some time to test the patch, because
> you unmap the dma in sdhci_finish_data rather than the sdhci_post_req.

Hi,

yes, this is not correct. We can perhaps differentiate according to the
COOKIE value. Should I fix it or are you going to prepare a patch based
on my RFC?

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [SHDCI] Heavy (thousands) DMA leaks Jiri Slaby <jslaby@suse.cz> - 2015-08-05 14:00 +0200
  [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks] Jiri Slaby <jslaby@suse.cz> - 2015-08-05 17:20 +0200
    Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA  leaks] Pavel Machek <pavel@ucw.cz> - 2015-08-05 18:30 +0200
    RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA  leaks] Chen Bough <Haibo.Chen@freescale.com> - 2015-08-06 09:50 +0200
      Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA  leaks] Jiri Slaby <jslaby@suse.cz> - 2015-08-06 11:10 +0200
        RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA  leaks] Chen Bough <Haibo.Chen@freescale.com> - 2015-08-06 11:20 +0200

csiph-web