Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201592

[PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode' assignment

Show all headers | View raw

This should have been removed by: 604cbe1de254 ("MIPS: loongson64/timer:
Migrate to new 'set-state' interface") commit, but it wasn't.

Remove it now.

Fixes: 604cbe1de254 ("MIPS: loongson64/timer: Migrate to new 'set-state' interface")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Ralf:

Not sure how it was left out in my series, but I thought it should have
been caught by the compilers as the function hpet_set_mode doesn't exist
today.

Either merge it with the offending commit or keep it separate.

 arch/mips/loongson64/loongson-3/hpet.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c
index 950096e8d7cd..bf9f1a77f0e5 100644
--- a/arch/mips/loongson64/loongson-3/hpet.c
+++ b/arch/mips/loongson64/loongson-3/hpet.c
@@ -228,7 +228,6 @@ void __init setup_hpet_timer(void)
 	cd->name = "hpet";
 	cd->rating = 320;
 	cd->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
-	cd->set_mode = hpet_set_mode;
 	cd->set_state_shutdown = hpet_set_state_shutdown;
 	cd->set_state_periodic = hpet_set_state_periodic;
 	cd->set_state_oneshot = hpet_set_state_oneshot;
-- 
2.4.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode' assignment Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-06 11:00 +0200
  Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode'  assignment Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-12 12:20 +0200
    Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode'  assignment Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-19 11:00 +0200
      Re: [PATCH] MIPS:loongson64:hpet: Drop the dangling 'set_mode'  assignment Ralf Baechle <ralf@linux-mips.org> - 2015-08-19 12:20 +0200

csiph-web