Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1201582
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node |
| Date | 2015-08-06 10:50 +0200 |
| Message-ID | <pUp2a-3HO-27@gated-at.bofh.it> (permalink) |
| References | <pTMtQ-6gT-3@gated-at.bofh.it> <pTMtS-6gT-45@gated-at.bofh.it> <pU1VU-3PS-31@gated-at.bofh.it> <pU1VV-3PS-37@gated-at.bofh.it> <pU7RD-3W5-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Kishon Vijay Abraham I <kishon@ti.com> [150805 07:28]:
> Hi Roger,
>
> On Wednesday 05 August 2015 01:38 PM, Roger Quadros wrote:
> > On 05/08/15 11:02, Roger Quadros wrote:
> >> Kishon,
> >>
> >> On 04/08/15 18:30, Kishon Vijay Abraham I wrote:
> >>> Add "syscon-otghs" property and remove the deprecated "ctrl-module"
> >>> property from MUSB devicetree node.
> >>>
> >>> Since "omap_control_usbotg" devicetree node is no longer used, remove
> >>> it.
> >>>
> >>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> >>> ---
> >>> arch/arm/boot/dts/omap4.dtsi | 8 +-------
> >>> 1 file changed, 1 insertion(+), 7 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> >>> index b27634d..2fb49a5 100644
> >>> --- a/arch/arm/boot/dts/omap4.dtsi
> >>> +++ b/arch/arm/boot/dts/omap4.dtsi
> >>> @@ -854,12 +854,6 @@
> >>> };
> >>> };
> >>>
> >>> - omap_control_usbotg: control-phy@4a00233c {
> >>> - compatible = "ti,control-phy-otghs";
> >>> - reg = <0x4a00233c 0x4>;
> >>> - reg-names = "otghs_control";
> >>> - };
> >>> -
> >>> usb_otg_hs: usb_otg_hs@4a0ab000 {
> >>> compatible = "ti,omap4-musb";
> >>> reg = <0x4a0ab000 0x7ff>;
> >>> @@ -872,7 +866,7 @@
> >>> multipoint = <1>;
> >>> num-eps = <16>;
> >>> ram-bits = <12>;
> >>> - ctrl-module = <&omap_control_usbotg>;
> >>> + syscon-otghs = <&scm_conf 0x33c>;
> >>
> >> All other properties were of the format "syscon-phy-foo".
> >> Why use a different format here?
> >>
> >
> > Ah, looks like we don't have a dedicated phy driver for this?
> > We will need to add a PHY driver I guess then and handle this register
> > in that driver rather than in the musb driver.
>
> I was explaining in the other thread to Tony on why this shouldn't be done in a
> PHY driver [1].
And I just suggested thhere that it should be in the drivers/phy/phy-omap-usb2.c
PHY driver instead of the MUSB driver.
Regards,
Tony
> [1] -> https://lkml.org/lkml/2015/8/5/455
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 00/10] ARM: dts: use syscon property instead of ctrl-module Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:40 +0200
[PATCH 07/10] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:40 +0200
Re: [PATCH 07/10] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Roger Quadros <rogerq@ti.com> - 2015-08-05 10:00 +0200
[PATCH 05/10] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:40 +0200
Re: [PATCH 05/10] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Roger Quadros <rogerq@ti.com> - 2015-08-05 10:00 +0200
[PATCH 08/10] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:40 +0200
Re: [PATCH 08/10] ARM: dts: OMAP5: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node Roger Quadros <rogerq@ti.com> - 2015-08-05 10:10 +0200
[PATCH 09/10] ARM: dts: omap4: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:40 +0200
Re: [PATCH 09/10] ARM: dts: omap4: Use "syscon-phy-power" instead of "ctrl-module" in USB PHY node Roger Quadros <rogerq@ti.com> - 2015-08-05 10:10 +0200
[PATCH 02/10] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:40 +0200
Re: [PATCH 02/10] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node Roger Quadros <rogerq@ti.com> - 2015-08-05 10:00 +0200
[PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:40 +0200
Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node Roger Quadros <rogerq@ti.com> - 2015-08-05 10:10 +0200
Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node Roger Quadros <rogerq@ti.com> - 2015-08-05 10:10 +0200
Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-05 16:30 +0200
Re: [PATCH 10/10] ARM: dts: omap4: Use "syscon-otghs" instead of "ctrl-module" in USB node Tony Lindgren <tony@atomide.com> - 2015-08-06 10:50 +0200
csiph-web