Groups > linux.kernel > #1201462

Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle
Date	2015-08-06 08:30 +0200
Message-ID	<pUmQF-E0-5@gated-at.bofh.it> (permalink)
References	<pNkTD-8cE-3@gated-at.bofh.it> <pNkTD-8cE-1@gated-at.bofh.it> <pU47o-6U1-13@gated-at.bofh.it> <pU8Xp-5uJ-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Suman Anna <s-anna@ti.com> [150805 08:35]:
> Hi Tony,
> 
> On 08/05/2015 05:28 AM, Tony Lindgren wrote:
> > * Dave Gerlach <d-gerlach@ti.com> [150717 13:59]:
> >> --- a/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt
> >> +++ b/Documentation/devicetree/bindings/mailbox/omap-mailbox.txt
> >> @@ -75,6 +75,14 @@ data that represent the following:
> >>      Cell #3 (usr_id)  - mailbox user id for identifying the interrupt line
> >>                          associated with generating a tx/rx fifo interrupt.
> >>  
> >> +Optional Properties:
> >> +--------------------
> >> +- ti,mbox-send-noirq:   Quirk flag to allow the client user of this sub-mailbox
> >> +                        to send messages without triggering a Tx ready interrupt,
> >> +                        and to control the Tx ticker. Should be used only on
> >> +                        sub-mailboxes used to communicate with WkupM3 remote
> >> +                        processor on AM33xx/AM43xx SoCs.
> >> +
> > 
> > Hmm can't you do this just by setting a flag in the device driver
> > based on the compatible string?
> 
> We can't because there can be other users like PRUSS which will use a
> sub-mailbox in a regular fashion. The compatible serves the IP and there
> can be multiple sub-mailboxes underneath it, and this quirk is needed
> only on the one that's used by the WkupM3.

OK

> Do you have any comments on this?

Up to you guys then to figure out what property is used for it then.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix  AM33xx CPU Idle Tony Lindgren <tony@atomide.com> - 2015-08-05 12:30 +0200
  Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to  fix AM33xx CPU Idle Suman Anna <s-anna@ti.com> - 2015-08-05 17:40 +0200
    Re: [PATCH v2 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix  AM33xx CPU Idle Tony Lindgren <tony@atomide.com> - 2015-08-06 08:30 +0200

csiph-web