Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1201139

Re: [PATCH] sky2: Add module parameter for passing the MAC address

Show all headers | View raw

Liviu Dudau <Liviu.Dudau@arm.com> :
> On Wed, Aug 05, 2015 at 05:40:57PM +0100, Stephen Hemminger wrote:
[...]
> > Yes, I can see that this can be a real problem, and other drivers
> > solve the problem. The standard method is to assign a random mac address
> > (and then let scripts overwrite) rather than introducing module parameter.
> > Module parameters are discouraged because they are device specific.
> > 
> 
> I agree. However, in my case, the boards people have assigned MAC addresses
> to the chip, they just didn't built the board in such a way as to allow one
> to store that MAC address in a permanent way :( And no, I can't use the DT
> because the chip is actually on the PCIe bus.
> 
> Even with the generation of a random address, it still needs to be copied
> into the device, so I would guess that a version of the patch I've sent is
> still relevant?

Assuming a random address is generated, could you elaborate what is needed
that sky2_set_mac_address fails to provide ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-05 18:00 +0200
  Re: [PATCH] sky2: Add module parameter for passing the MAC address Stephen Hemminger <stephen@networkplumber.org> - 2015-08-05 18:50 +0200
    Re: [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-05 19:20 +0200
      Re: [PATCH] sky2: Add module parameter for passing the MAC address Francois Romieu <romieu@fr.zoreil.com> - 2015-08-05 22:40 +0200
        Re: [PATCH] sky2: Add module parameter for passing the MAC address Stephen Hemminger <stephen@networkplumber.org> - 2015-08-06 01:20 +0200
          Re: [PATCH] sky2: Add module parameter for passing the MAC address Florian Fainelli <f.fainelli@gmail.com> - 2015-08-06 02:40 +0200
            [PATCH v2 net-next] sky2: use random address if EEPROM is bad Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-11 16:40 +0200
              Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad Stephen Hemminger <stephen@networkplumber.org> - 2015-08-11 19:10 +0200
                Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-12 11:40 +0200
                Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad Stephen Hemminger <stephen@networkplumber.org> - 2015-08-12 17:30 +0200
                Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-12 18:10 +0200
              Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-11 21:00 +0200
                Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-12 11:20 +0200
  Re: [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-05 19:20 +0200
  Re: [PATCH] sky2: Add module parameter for passing the MAC address David Miller <davem@davemloft.net> - 2015-08-06 02:20 +0200
    Re: [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau <Liviu.Dudau@arm.com> - 2015-08-06 12:40 +0200

csiph-web