Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1203010

[Patch v4] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification

From Tal Shorer <tal.shorer@gmail.com>
Newsgroups linux.kernel
Subject [Patch v4] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
Date 2015-08-07 21:40 +0200
Message-ID <pUVEK-Et-11@gated-at.bofh.it> (permalink)
References <pUVEK-Et-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From the usb 3.1 spec available at http://www.usb.org/developers/docs/
table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
GetPortErrorCount as:

Request			bmRequestType	bRequest		wValue		wIndex	wLength	Data
SetHubDepth		00100000B	SET_HUB_DEPTH		Hub Depth	Zero	Zero	None
GetPortErrorCount	10100011B	GET_PORT_ERR_COUNT	Zero		Port	Two	Number of Link Errors on this port

Fix these two values to match the spec.

Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
 include/linux/usb/hcd.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index c9aa779..d2784c1 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
 
 /*-------------------------------------------------------------------------*/
 
-/* class requests from USB 3.0 hub spec, table 10-5 */
-#define SetHubDepth		(0x3000 | HUB_SET_DEPTH)
-#define GetPortErrorCount	(0x8000 | HUB_GET_PORT_ERR_COUNT)
+/* class requests from USB 3.1 hub spec, table 10-7 */
+#define SetHubDepth		(0x2000 | HUB_SET_DEPTH)
+#define GetPortErrorCount	(0xa300 | HUB_GET_PORT_ERR_COUNT)
 
 /*
  * Generic bandwidth allocation constants/support
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Tal Shorer <tal.shorer@gmail.com> - 2015-08-07 20:00 +0200
  Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and  GetPortErrorCount to match USB 3.1 specification Greg KH <gregkh@linuxfoundation.org> - 2015-08-07 20:10 +0200
  Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and  GetPortErrorCount to match USB 3.1 specification Greg KH <gregkh@linuxfoundation.org> - 2015-08-07 20:10 +0200
    [Patch v2] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Tal Shorer <tal.shorer@gmail.com> - 2015-08-07 20:20 +0200
      Re: [Patch v2] usb: hcd.h: Fix the values of SetHubDepth and  GetPortErrorCount to match USB 3.1 specification Tal Shorer <tal.shorer@gmail.com> - 2015-08-07 20:20 +0200
    [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Tal Shorer <tal.shorer@gmail.com> - 2015-08-07 20:20 +0200
      Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and  GetPortErrorCount to match USB 3.1 specification Greg KH <gregkh@linuxfoundation.org> - 2015-08-07 20:50 +0200
        Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and  GetPortErrorCount to match USB 3.1 specification Tal Shorer <tal.shorer@gmail.com> - 2015-08-07 20:50 +0200
          Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and  GetPortErrorCount to match USB 3.1 specification Greg KH <gregkh@linuxfoundation.org> - 2015-08-07 21:40 +0200
            [Patch v4] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Tal Shorer <tal.shorer@gmail.com> - 2015-08-07 21:40 +0200

csiph-web