Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202754

[spi:topic/mtk 2/2] drivers/spi/spi-mt65xx.c:362:24: sparse: incorrect type in argument 1 (different base types)

Show all headers | View raw

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi topic/mtk
head:   a568231f463225eb31593f71446a267a03ae0528
commit: a568231f463225eb31593f71446a267a03ae0528 [2/2] spi: mediatek: Add spi bus for Mediatek MT8173
reproduce:
  # apt-get install sparse
  git checkout a568231f463225eb31593f71446a267a03ae0528
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/spi/spi-mt65xx.c:362:24: sparse: incorrect type in argument 1 (different base types)
   drivers/spi/spi-mt65xx.c:362:24:    expected unsigned int [unsigned] val
   drivers/spi/spi-mt65xx.c:362:24:    got restricted __le32 [usertype] <noident>
   drivers/spi/spi-mt65xx.c:364:24: sparse: incorrect type in argument 1 (different base types)
   drivers/spi/spi-mt65xx.c:364:24:    expected unsigned int [unsigned] val
   drivers/spi/spi-mt65xx.c:364:24:    got restricted __le32 [usertype] <noident>
>> drivers/spi/spi-mt65xx.c:734:24: sparse: symbol 'mtk_spi_driver' was not declared. Should it be static?

Please review and possibly fold the followup patch.

vim +362 drivers/spi/spi-mt65xx.c

   346			mult_delta = mtk_spi_get_mult_delta(mdata->tx_sgl_len);
   347			mdata->xfer_len = mdata->tx_sgl_len - mult_delta;
   348			mdata->tx_sgl_len = mult_delta;
   349		} else if (mdata->rx_sgl_len) {
   350			mult_delta = mtk_spi_get_mult_delta(mdata->rx_sgl_len);
   351			mdata->xfer_len = mdata->rx_sgl_len - mult_delta;
   352			mdata->rx_sgl_len = mult_delta;
   353		}
   354	}
   355	
   356	static void mtk_spi_setup_dma_addr(struct spi_master *master,
   357					   struct spi_transfer *xfer)
   358	{
   359		struct mtk_spi *mdata = spi_master_get_devdata(master);
   360	
   361		if (mdata->tx_sgl)
 > 362			writel(cpu_to_le32(xfer->tx_dma), mdata->base + SPI_TX_SRC_REG);
   363		if (mdata->rx_sgl)
   364			writel(cpu_to_le32(xfer->rx_dma), mdata->base + SPI_RX_DST_REG);
   365	}
   366	
   367	static int mtk_spi_fifo_transfer(struct spi_master *master,
   368					 struct spi_device *spi,
   369					 struct spi_transfer *xfer)
   370	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[spi:topic/mtk 2/2] drivers/spi/spi-mt65xx.c:362:24: sparse:  incorrect type in argument 1 (different base types) kbuild test robot <fengguang.wu@intel.com> - 2015-08-07 16:40 +0200
  Re: [spi:topic/mtk 2/2] drivers/spi/spi-mt65xx.c:362:24: sparse:  incorrect type in argument 1 (different base types) lei liu <leilk.liu@mediatek.com> - 2015-08-11 04:50 +0200
    Re: [spi:topic/mtk 2/2] drivers/spi/spi-mt65xx.c:362:24: sparse:  incorrect type in argument 1 (different base types) Mark Brown <broonie@kernel.org> - 2015-08-11 11:10 +0200

csiph-web