Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202344

Re: [PATCH] stmmac: dwmac-ipq806x: fix static checker warning

Show all headers | View raw

From: Mathieu Olivari <mathieu@codeaurora.org>
Date: Tue,  4 Aug 2015 17:25:02 -0700

> The patch b1c17215d718: "stmmac: add ipq806x glue layer", leads to the
> following static checker warning:
> 
> .../stmmac/dwmac-ipq806x.c:314 ipq806x_gmac_probe()
> warn: double left shift '1 << (1 << gmac->id)'
> 
> The NSS_COMMON_CLK_SRC_CTRL_OFFSET macro is used once as an offset, and
> once as a mask, which is a bug indeed. We'll fix it by defining the
> offset as the real offset value and computing the mask from it when
> required.
> 
> Tested on IPQ806x ref designs AP148 & DB149.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Mathieu Olivari <mathieu@codeaurora.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] stmmac: dwmac-ipq806x: fix static checker warning Mathieu Olivari <mathieu@codeaurora.org> - 2015-08-05 02:30 +0200
  Re: [PATCH] stmmac: dwmac-ipq806x: fix static checker warning David Miller <davem@davemloft.net> - 2015-08-07 09:20 +0200

csiph-web