Groups > linux.kernel > #1202293

Re: [PATCH 07/13] twl4030_charger: distinguish between USB current and 'AC' current

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/13] twl4030_charger: distinguish between USB current and 'AC' current
Date	2015-08-07 07:20 +0200
Message-ID	<pUIeu-6qG-5@gated-at.bofh.it> (permalink)
References	<pRJTr-7hl-3@gated-at.bofh.it> <pRJTt-7hl-39@gated-at.bofh.it> <pUGml-3IK-5@gated-at.bofh.it> <pUGPn-4gu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

This actually slipped through my review. IMHO madc should be
accessed through IIO, as already done for twl4030-madc-battery
and rx51-battery. That way the custom API can be removed at
some point.

Anyway, I queued the below patch with Tony's ACK to fix the build
issue in next.

On Fri, Aug 07, 2015 at 01:45:25PM +1000, NeilBrown wrote:
> From: NeilBrown <neil@brown.name>
> Date: Fri, 7 Aug 2015 13:44:37 +1000
> Subject: [PATCH] twl4030_charger: fix compile error when TWL4030_MADC not
>  available.
> 
> We can only use the madc to check for 'ac' availability
> if the madc has been compiled in.
> If not: assume always using USB.
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: NeilBrown <neil@brown.name>
> 
> diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
> index c7432f532a83..265fd236f4c0 100644
> --- a/drivers/power/twl4030_charger.c
> +++ b/drivers/power/twl4030_charger.c
> @@ -91,6 +91,21 @@
>  #define TWL4030_MSTATEC_COMPLETE1	0x0b
>  #define TWL4030_MSTATEC_COMPLETE4	0x0e
>  
> +#if IS_ENABLED(CONFIG_TWL4030_MADC)
> +/*
> + * If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
> + * then AC is available.
> + */
> +static inline int ac_available(void)
> +{
> +	return twl4030_get_madc_conversion(11) > 4500;
> +}
> +#else
> +static inline int ac_available(void)
> +{
> +	return 0;
> +}
> +#endif
>  static bool allow_usb;
>  module_param(allow_usb, bool, 0644);
>  MODULE_PARM_DESC(allow_usb, "Allow USB charge drawing default current");
> @@ -263,7 +278,7 @@ static int twl4030_charger_update_current(struct twl4030_bci *bci)
>  	 * If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
>  	 * and AC is enabled, set current for 'ac'
>  	 */
> -	if (twl4030_get_madc_conversion(11) > 4500) {
> +	if (ac_available()) {
>  		cur = bci->ac_cur;
>  		bci->ac_is_active = true;
>  	} else {

-- Sebastian

Thread

Re: [PATCH 07/13] twl4030_charger: distinguish between USB current  and 'AC' current Tony Lindgren <tony@atomide.com> - 2015-08-07 05:20 +0200
  Re: [PATCH 07/13] twl4030_charger: distinguish between USB current  and 'AC' current NeilBrown <neil@brown.name> - 2015-08-07 05:50 +0200
    Re: [PATCH 07/13] twl4030_charger: distinguish between USB current  and 'AC' current Tony Lindgren <tony@atomide.com> - 2015-08-07 06:30 +0200
    Re: [PATCH 07/13] twl4030_charger: distinguish between USB current  and 'AC' current Sebastian Reichel <sre@kernel.org> - 2015-08-07 07:20 +0200
      Re: [PATCH 07/13] twl4030_charger: distinguish between USB current  and 'AC' current NeilBrown <neil@brown.name> - 2015-08-07 07:30 +0200

csiph-web