Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1202273
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled |
| Date | 2015-08-07 05:50 +0200 |
| Message-ID | <pUGPn-4gu-3@gated-at.bofh.it> (permalink) |
| References | <pUtIu-271-11@gated-at.bofh.it> <pUtIv-271-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
I would suggest you sending such patches as reply to the earlier
threads only, instead of a new chain. This will save your time.
For example, you will need to resend other patches unnecessarily if I
NAK this patch :)
On 06-08-15, 15:41, Bartlomiej Zolnierkiewicz wrote:
> Add cpufreq_boost_enabled_generic_attr table and use it in
> cpufreq-dt driver instead of cpufreq_generic_attr one when
> boost support is enabled. As a result scaling_boost_freqs
> sysfs attribute is available when cpufreq-dt driver is
> used and boost support is enabled.
>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/cpufreq/cpufreq-dt.c | 3 +++
> drivers/cpufreq/freq_table.c | 7 +++++++
> include/linux/cpufreq.h | 1 +
> 3 files changed, 11 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index b9259ab..7b091c0 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -182,6 +182,8 @@ try_again:
> return ret;
> }
>
> +static struct cpufreq_driver dt_cpufreq_driver;
> +
> static int cpufreq_init(struct cpufreq_policy *policy)
> {
> struct cpufreq_frequency_table *freq_table;
> @@ -336,6 +338,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> ret = cpufreq_enable_boost_support();
> if (ret)
> goto out_free_cpufreq_table;
> + dt_cpufreq_driver.attr = cpufreq_boost_enabled_generic_attr;
> }
>
> policy->cpuinfo.transition_latency = transition_latency;
> diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> index a8f1daf..5a00a09 100644
> --- a/drivers/cpufreq/freq_table.c
> +++ b/drivers/cpufreq/freq_table.c
> @@ -300,6 +300,13 @@ struct freq_attr *cpufreq_generic_attr[] = {
> };
> EXPORT_SYMBOL_GPL(cpufreq_generic_attr);
>
> +struct freq_attr *cpufreq_boost_enabled_generic_attr[] = {
> + &cpufreq_freq_attr_scaling_available_freqs,
> + &cpufreq_freq_attr_scaling_boost_freqs,
> + NULL,
> +};
> +EXPORT_SYMBOL_GPL(cpufreq_boost_enabled_generic_attr);
This isn't scalable. We can't create a new generic structure every time
a entry comes in. Rather we should leave the generic attr for
cpufreq-dt and do something like this in the cpufreq-dt driver (And
that patch should rather go via cpufreq tree and not ARM SoC)..
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index a5b6a854661f..e229258ad791 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -36,6 +36,12 @@ struct private_data {
unsigned int voltage_tolerance; /* in percentage */
};
+static struct freq_attr *cpufreq_dt_attr[] = {
+ &cpufreq_freq_attr_scaling_available_freqs,
+ NULL, /* Extra space for boost-attr if required */
+ NULL,
+};
+
static int set_target(struct cpufreq_policy *policy, unsigned int index)
{
struct dev_pm_opp *opp;
@@ -337,6 +343,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
ret = cpufreq_enable_boost_support();
if (ret)
goto out_free_cpufreq_table;
+ cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs;
}
policy->cpuinfo.transition_latency = transition_latency;
@@ -412,7 +419,7 @@ static struct cpufreq_driver dt_cpufreq_driver = {
.exit = cpufreq_exit,
.ready = cpufreq_ready,
.name = "cpufreq-dt",
- .attr = cpufreq_generic_attr,
+ .attr = cpufreq_dt_attr,
};
static int dt_cpufreq_probe(struct platform_device *pdev)
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-06 15:50 +0200
[PATCH v4 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-06 15:50 +0200
[PATCH v4 2/6] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-06 15:50 +0200
[PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-06 15:50 +0200
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 05:50 +0200
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-07 12:40 +0200
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 12:50 +0200
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-07 13:20 +0200
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 13:40 +0200
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-08 00:00 +0200
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-08 04:10 +0200
[PATCH v4 6/6] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-06 15:50 +0200
Re: [PATCH v4 6/6] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 06:40 +0200
[PATCH v4 5/6] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-06 15:50 +0200
[PATCH v4 3/6] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-06 15:50 +0200
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Kukjin Kim <kgene@kernel.org> - 2015-08-07 02:00 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 06:00 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 06:00 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-07 06:20 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 06:40 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-07 07:00 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 07:20 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-07 13:40 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 13:50 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-07 13:50 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 14:00 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-08 00:00 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-08 04:10 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-08 09:30 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-08 16:00 +0200
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Kukjin Kim <kgene@kernel.org> - 2015-08-10 03:30 +0200
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-11 04:30 +0200
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform Kukjin Kim <kgene@kernel.org> - 2015-08-11 10:00 +0200
csiph-web