Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1200972
| From | David Sterba <dsterba@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 8/8] btrfs: use __GFP_NOFAIL in alloc_btrfs_bio |
| Date | 2015-08-05 18:40 +0200 |
| Message-ID | <pU9Ts-6QK-9@gated-at.bofh.it> (permalink) |
| References | <pU3Em-66q-11@gated-at.bofh.it> <pU3En-66q-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 05, 2015 at 11:51:24AM +0200, mhocko@kernel.org wrote: > From: Michal Hocko <mhocko@suse.com> > > alloc_btrfs_bio is relying on GFP_NOFS to allocate a bio but since "mm: > page_alloc: do not lock up GFP_NOFS allocations upon OOM" this is > allowed to fail which can lead to > [ 37.928625] kernel BUG at fs/btrfs/extent_io.c:4045 > > This is clearly undesirable and the nofail behavior should be explicit > if the allocation failure cannot be tolerated. > > Signed-off-by: Michal Hocko <mhocko@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 8/8] btrfs: use __GFP_NOFAIL in alloc_btrfs_bio mhocko@kernel.org - 2015-08-05 12:00 +0200 Re: [RFC 8/8] btrfs: use __GFP_NOFAIL in alloc_btrfs_bio David Sterba <dsterba@suse.com> - 2015-08-05 18:40 +0200 [RFC -v2 8/8] btrfs: use __GFP_NOFAIL in alloc_btrfs_bio Michal Hocko <mhocko@kernel.org> - 2015-08-18 12:50 +0200
csiph-web