Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200844

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Show all headers | View raw

Hi Tony,

On Wednesday 05 August 2015 03:17 PM, Tony Lindgren wrote:
> * Kishon Vijay Abraham I <kishon@ti.com> [150727 04:27]:
>> vsel_reg and enable_reg of the pbias regulator descriptor should actually
>> have the offset from syscon. However after the pbias device tree node
>> is moved as a child node of syscon, vsel_reg and enable_reg has the
>> absolute address because of the address translation that happens while
>> creating device from device tree node.
>> So avoid using platform_get_resource and use of_get_address in order to
>> get only the offset (untranslated address) and populate these in
>> vsel_reg and enable_reg.
> 
> I think this gets fixed automatically with your other series
> adding the "simple-bus" to the nodes. For the children of_ioremap

Nope. The probe of pbias regulator fails as Grygorii has already pointed out
here [1].

Thanks
Kishon

[1] -> http://www.spinics.net/lists/linux-omap/msg120462.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Tony Lindgren <tony@atomide.com> - 2015-08-05 11:50 +0200
  Re: [PATCH 1/2] regulator: pbias: use untranslated address to program  pbias regulator Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-05 17:00 +0200
    Re: [PATCH 1/2] regulator: pbias: use untranslated address to  program pbias regulator Tony Lindgren <tony@atomide.com> - 2015-08-06 08:30 +0200
      Re: [PATCH 1/2] regulator: pbias: use untranslated address to program  pbias regulator Grygorii Strashko <grygorii.strashko@ti.com> - 2015-08-06 12:00 +0200

csiph-web