Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200838

Re: [PATCH v3] thermal: Fix thermal_zone_of_sensor_register to match documentation

Show all headers | View raw

On 08/05/2015 02:57 AM, Punit Agrawal wrote:
> thermal_zone_of_sensor_register is documented as returning a pointer
> to either a valid thermal_zone_device on success, or a corresponding
> ERR_PTR() value.
>
> In contrast, the function returns NULL when THERMAL_OF is configured
> off. Fix this.
>
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Zhang Rui <rui.zhang@intel.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Hi Guenter,
>
> It was pointed out that ENOSYS is frowned upon for anything other than
> indicating lack of support for a syscall. The rest of the functions in
> the file use ENODEV. Updating thermal_zone_of_sensor_register to do
> the same.
>
> Could you please re-ack if you're ok with this change?
>
> Thanks,
> Punit
>
>   include/linux/thermal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 037e9df..f344e51 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -364,7 +364,7 @@ static inline struct thermal_zone_device *
>   thermal_zone_of_sensor_register(struct device *dev, int id, void *data,
>   				const struct thermal_zone_of_device_ops *ops)
>   {
> -	return NULL;
> +	return ERR_PTR(-ENODEV);
>   }
>
>   static inline
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] thermal: Fix thermal_zone_of_sensor_register to match documentation Punit Agrawal <punit.agrawal@arm.com> - 2015-08-05 12:00 +0200
  Re: [PATCH v3] thermal: Fix thermal_zone_of_sensor_register to match  documentation Guenter Roeck <linux@roeck-us.net> - 2015-08-05 17:00 +0200

csiph-web