Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200759

Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call.

Show all headers | View raw

On 05.08.2015 15:48, Rafael J. Wysocki wrote:
> On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote:
>> From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>>
>> Fixes the following build error when building drivers as modules:
>>
>>   ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko] undefined!
>>   ERROR: "acpi_dev_prop_read_single" [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined!
>
> Can you please tell me why the drivers in question use that function
> directly, although they aren't supposed to?
>
> Clearly, their authors had not tried to build them as modules or they
> would have noticed the problem at the development stage already.
>
> What would be wrong with using the generic device properties API instead?
>
Yes, you are right. We should use:
int device_property_read_u64_array(struct device *dev, const char 
*propname, u64 *val, size_t nval);

Regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] acpi, property: Export acpi_dev_prop_read_single call. David Daney <ddaney.cavm@gmail.com> - 2015-08-05 01:10 +0200
  Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-05 15:30 +0200
    Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. Tomasz Nowicki <tomasz.nowicki@linaro.org> - 2015-08-05 15:50 +0200
      Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. David Daney <ddaney@caviumnetworks.com> - 2015-08-05 19:30 +0200
        Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. David Daney <ddaney.cavm@gmail.com> - 2015-08-05 22:20 +0200
          Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-06 01:00 +0200
            Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-06 01:20 +0200
            Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-06 01:30 +0200
              Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call. David Daney <ddaney.cavm@gmail.com> - 2015-08-06 02:00 +0200

csiph-web