Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200825

Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

Show all headers | View raw

On Wed, Aug 05, 2015 at 12:04:25PM +0530, Vaibhav Hiremath wrote:
> 
> 
> On Monday 27 July 2015 07:39 PM, Matt Porter wrote:
> >On Tue, Jul 21, 2015 at 06:11:02PM +0530, Vaibhav Hiremath wrote:
> >>Driver will now supports enable/disable across msg xfer, which user
> >>can control it by new DT property -
> >>
> >>i2c-disable-after-xfer : If set, driver will disable I2C module after msg
> >>  xfer and enable it back before xfer.
> >
> >If this is a new property specific to this Marvell part, it needs
> >the vendor prefix as in mrvl,i2c-disable-after-xfer
> >
> 
> We discussed about this, I think in V1 or V2. Decided to use generic
> name, as feature (in turn property) could be used by other drivers as
> well.

Ahh, ok, thanks...coming in too late on this one. :)

> >Or, it couldn't hurt to start an i2c.txt for generic i2c bindings
> >and store it there as this and others later in this series would
> >reasonably apply to other controllers.
> >
> 
> Yeah, we could start i2c.txt, probably better to have separate new
> patch all together.

Great, yes, I've always found it hard to follow i2c generic bindings
since they aren't defined in a clear place like other similar hardware
(e.g. SPI).

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer'  to i2c-pxa Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-05 08:40 +0200
  Re: [PATCH-v5 1/5] Documentation: binding: add new property  'disable_after_xfer' to i2c-pxa Wolfram Sang <wsa@the-dreams.de> - 2015-08-05 10:50 +0200
    Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer'  to i2c-pxa Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-05 11:50 +0200
    Re: [PATCH-v5 1/5] Documentation: binding: add new property  'disable_after_xfer' to i2c-pxa Matt Porter <mporter@konsulko.com> - 2015-08-05 16:30 +0200
  Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer'  to i2c-pxa Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-05 16:30 +0200
  Re: [PATCH-v5 1/5] Documentation: binding: add new property  'disable_after_xfer' to i2c-pxa Matt Porter <mporter@konsulko.com> - 2015-08-05 16:30 +0200

csiph-web