Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200638

Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address

Show all headers | View raw

Hi Stefano,

On 05/08/15 10:49, Stefano Stabellini wrote:
>>  /* VIRT <-> MACHINE conversion */
>>  #define virt_to_mfn(v)		(pfn_to_mfn(virt_to_pfn(v)))
>> @@ -96,7 +115,7 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
>>  
>>  bool xen_arch_need_swiotlb(struct device *dev,
>>  			   unsigned long pfn,
>> -			   unsigned long mfn);
>> +			   unsigned long dfn);
>>  unsigned long xen_get_swiotlb_free_pages(unsigned int order);
> 
> You missed a bunch of dfn->bfn renamings.

Sorry, I forgot to double check that before sending the patch. I will
fix it in the next version.

> Aside from those and the commit message error:
> 
> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Thank you!

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address Julien Grall <julien.grall@citrix.com> - 2015-08-04 20:20 +0200
  Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are  dealing with DMA address Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-08-05 12:00 +0200
    Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are  dealing with DMA address Julien Grall <julien.grall@citrix.com> - 2015-08-05 12:40 +0200

csiph-web